Timestamps are in GMT/BST.
[6:52] -barjavel.freenode.net- *** Looking up your hostname...
[6:52] -barjavel.freenode.net- *** Checking Ident
[6:52] -barjavel.freenode.net- *** Found your hostname
[6:52] -barjavel.freenode.net- *** No Ident response
[6:52] * DuraLogBot (~PircBot@atlas.duraspace.org) has joined #duraspace
[6:52] * Topic is '[Welcome to DuraSpace - This channel is logged - http://irclogs.duraspace.org/]'
[6:52] * Set by cwilper!ad579d86@gateway/web/freenode/ip.173.87.157.134 on Fri Oct 22 01:19:41 UTC 2010
[8:44] * awoods (~awoods@c-67-165-245-76.hsd1.co.comcast.net) Quit (Ping timeout: 260 seconds)
[8:47] * awoods (~awoods@c-67-165-245-76.hsd1.co.comcast.net) has joined #duraspace
[9:11] * jonathangee_ (~jonathang@142.68.37.238) has joined #duraspace
[9:12] * jonathangee (~jonathang@142.68.37.238) Quit (*.net *.split)
[13:08] * mhwood (mwood@mhw.ulib.iupui.edu) has joined #duraspace
[13:49] * tdonohue (~tdonohue@c-50-179-112-246.hsd1.il.comcast.net) has joined #duraspace
[17:34] * hpottinger (~hpottinge@mu-161244.dhcp.missouri.edu) has joined #duraspace
[19:12] * helix84 (~ctenar@195.178.95.132) has joined #duraspace
[20:00] * bollini (~bollini@host190-215-dynamic.35-79-r.retail.telecomitalia.it) has joined #duraspace
[20:00] * kstamatis (6df2ac96@gateway/web/freenode/ip.109.242.172.150) has joined #duraspace
[20:00] <tdonohue> Hi all, it's time for the DSpace Developers Meeting. Today's agenda: https://wiki.duraspace.org/display/DSPACE/DevMtg+2013-12-04
[20:01] <kompewter> [ DevMtg 2013-12-04 - DSpace - DuraSpace Wiki ] - https://wiki.duraspace.org/display/DSPACE/DevMtg+2013-12-04
[20:01] <tdonohue> So, today's main topic is obviously 4.0 status updates, etc.
[20:02] <tdonohue> A few of us were also reviewing tickets that are still marked as "fix for 4.0" (in the previous hour). There still seems to be some good bug fixes out there, so we may want to determine how to tackle the remainder of the review
[20:02] <mhwood> RC2 is out. It's already known to have some broken Javascript, so RC3 will be cut Friday after 1600 UTC.
[20:03] <bollini> should we go ahead with the list of jira issues for 4.0?
[20:04] <bollini> https://jira.duraspace.org/browse/DS-1680
[20:04] <kompewter> [ [DS-1680] using the back button to change collection during ingest - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-1680
[20:04] <kompewter> [ https://jira.duraspace.org/browse/DS-1680 ] - [DS-1680] using the back button to change collection during ingest - DuraSpace JIRA
[20:04] <tdonohue> we may want to continue these jira reviews...I'm very worried we'll be leaving behind good fixes otherwise.
[20:05] <tdonohue> (as many of these tickets seem to already have PRs which have had some testing, and just need merging)
[20:07] <bollini> someone volunteer for testing that? https://github.com/DSpace/DSpace/pull/310
[20:07] <kompewter> [ DS-1680 Handle user using the back button to change collection during ingest by gmh04 · Pull Request #310 · DSpace/DSpace · GitHub ] - https://github.com/DSpace/DSpace/pull/310
[20:08] <tdonohue> 1680 / PR310: Slightly worried about this. It seems like it would keep creating new WorkspaceItems each time you hit the back button? Would this cause a ton of empty workspace items to be generated?
[20:09] <tdonohue> haven't verified...just noting it seems to be creating workspace items, without cleaning up any that may already exist for this submission? Or maybe I'm misunderstanding
[20:09] <bollini> probably it is what happen in jspui too. But it looks better to me have some item to remove that a wrong in progress submission
[20:10] <tdonohue> I suggest this could be marked "needs volunteer" and rescheduled for 4.1, unless we have an immediate volunteer. Although this is a bit annoying, it doesn't sound like a show-stopper
[20:10] <mhwood> Yes.
[20:10] <mhwood> 4.1. Needs more study.
[20:10] * PeterDietz (~peterdiet@dietz72m1.lib.ohio-state.edu) has joined #duraspace
[20:11] <bollini> https://jira.duraspace.org/browse/DS-1651
[20:11] <kompewter> [ [DS-1651] Reinstate the ability to add a CC Licence post submission in the JSPUI - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-1651
[20:11] <kompewter> [ https://jira.duraspace.org/browse/DS-1651 ] - [DS-1651] Reinstate the ability to add a CC Licence post submission in the JSPUI - DuraSpace JIRA
[20:11] <tdonohue> I rescheduled it
[20:11] <tdonohue> (1680 is rescheduled, I mean)
[20:11] * aschweer (~schweer@schweer.its.waikato.ac.nz) has joined #duraspace
[20:12] <mhwood> There is still some uncertainty on 1651.
[20:12] <PeterDietz> hi all, just joined. Had work meetings...
[20:12] <tdonohue> PeterDietz - we are reviewing JIRA tickets marked "fix for 4.0"
[20:13] <mhwood> 1651 has no code yet. Reschedule.
[20:13] <bollini> yes, I have rescheduled it
[20:13] <bollini> https://jira.duraspace.org/browse/DS-1628
[20:13] <kompewter> [ [DS-1628] launching a command emits excessive log lines to stderr - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-1628
[20:13] <kompewter> [ https://jira.duraspace.org/browse/DS-1628 ] - [DS-1628] launching a command emits excessive log lines to stderr - DuraSpace JIRA
[20:14] <mhwood> No code. Reschedule.
[20:14] <tdonohue> 1628 needs code & volunteer.
[20:14] <tdonohue> done, rescheduled
[20:14] <bollini> https://jira.duraspace.org/browse/DS-1578
[20:14] <kompewter> [ [DS-1578] improve clean_database ant target to work better with Oracle - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-1578
[20:14] <kompewter> [ https://jira.duraspace.org/browse/DS-1578 ] - [DS-1578] improve clean_database ant target to work better with Oracle - DuraSpace JIRA
[20:15] <mhwood> No code. Reschedule.
[20:15] <tdonohue> assigned, but no code. Reschedule (unless hpottinger says it's simple)
[20:16] <tdonohue> actually this is a major change/refactor of "Ant". I don't like this idea, this late in the game.
[20:16] <hpottinger> I had forgotten this idea, but I do have some newer clean-database.sql since I've managed to dust off my Oracle testing environment
[20:17] <hpottinger> +1 to putting it off, though, for the reasons tdonohue mentions
[20:17] <tdonohue> I suggest reschedule for *5.0*. I'll do so.
[20:17] <bollini> ok
[20:18] <bollini> https://jira.duraspace.org/browse/DS-1555
[20:18] <kompewter> [ [DS-1555] Empty Listitem in pagination divs - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-1555
[20:18] <kompewter> [ https://jira.duraspace.org/browse/DS-1555 ] - [DS-1555] Empty Listitem in pagination divs - DuraSpace JIRA
[20:18] <mhwood> No code. Reschedule.
[20:18] <tdonohue> Agreed. I rescheduled for 4.1
[20:18] <bollini> https://jira.duraspace.org/browse/DS-1546
[20:18] <kompewter> [ [DS-1546] org.dspace.authenticate.ShibAuthentication.findMultipleHeaders doesn't work for multiple headers, and provides incorrect config advice - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-1546
[20:18] <kompewter> [ https://jira.duraspace.org/browse/DS-1546 ] - [DS-1546] org.dspace.authenticate.ShibAuthentication.findMultipleHeaders doesn't work for multiple headers, and provides incorrect config advice - DuraSpace JIRA
[20:19] <tdonohue> no code, but hpottinger says "I have a patch"
[20:20] <tdonohue> If there's a patch/PR that is a confirmed fix, I say we get it in (if possible). It sounds like the work is mostly done, based on hpottinger's description here
[20:20] <mhwood> Agreed.
[20:20] <hpottinger> oh, I do, it conflicts with another change
[20:20] <bollini> ok, keep it open for hpottinger
[20:21] <tdonohue> hpottinger: care to explain? Or add a comment to the ticket? Should we reschedule then? Or do you need more eyes?
[20:21] <hpottinger> reschedule, it conflicts with an earlier change to Shib auth, swapping attributes for headers
[20:22] <tdonohue> ok, fine then. rescheduled for 4.1
[20:22] <bollini> https://jira.duraspace.org/browse/DS-1543
[20:22] <kompewter> [ https://jira.duraspace.org/browse/DS-1543 ] - [DS-1543] field labels not displayed in RSS 2.0 feed - DuraSpace JIRA
[20:22] <kompewter> [ [DS-1543] field labels not displayed in RSS 2.0 feed - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-1543
[20:22] <tdonohue> no code. needs volunteer. reschedule
[20:23] <bollini> https://jira.duraspace.org/browse/DS-1531
[20:23] <kompewter> [ [DS-1531] bug in current DSpace (3.1) with log importing - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-1531
[20:23] <kompewter> [ https://jira.duraspace.org/browse/DS-1531 ] - [DS-1531] bug in current DSpace (3.1) with log importing - DuraSpace JIRA
[20:23] <tdonohue> needs volunteer. no code. reschedule 1531
[20:24] <bollini> https://jira.duraspace.org/browse/DS-1530
[20:24] <kompewter> [ [DS-1530] create-administrator and skipping the email field - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-1530
[20:24] <kompewter> [ https://jira.duraspace.org/browse/DS-1530 ] - [DS-1530] create-administrator and skipping the email field - DuraSpace JIRA
[20:24] * tdonohue just as a note, I'm rescheduling things behind the scenes..just not saying so here
[20:24] <tdonohue> 1530 - close it? Says it is "merged"
[20:24] <bollini> this has been merged
[20:25] <mhwood> 1530 is merged. Left for submitter's comments, but can close.
[20:25] <tdonohue> closed. (submitter can still comment on a closed ticket)
[20:25] <bollini> https://jira.duraspace.org/browse/DS-1481
[20:25] <kompewter> [ [DS-1481] "dc.date.issued" is often incorrectly set (reported from Google) - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-1481
[20:25] <kompewter> [ https://jira.duraspace.org/browse/DS-1481 ] - [DS-1481] "dc.date.issued" is often incorrectly set (reported from Google) - DuraSpace JIRA
[20:26] <mhwood> Awaiting the cleanup curation task. Reschedule?
[20:26] <tdonohue> 1481: This is "mostly fixed". The ticket itself involves too many things... We may want to just close it and I'll open up a new ticket around the "cleanup curation task"
[20:26] <mhwood> That sounds good.
[20:26] <bollini> tdonohue +1
[20:26] <tdonohue> I'll deal with 1481 after this mtg.
[20:26] <bollini> https://jira.duraspace.org/browse/DS-1485
[20:26] <kompewter> [ https://jira.duraspace.org/browse/DS-1485 ] - [DS-1485] bitstream access icon alt text empty when bitstream has no permissions - DuraSpace JIRA
[20:26] <kompewter> [ [DS-1485] bitstream access icon alt text empty when bitstream has no permissions - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-1485
[20:28] <tdonohue> 1485. Has a fix, looks reasonable.
[20:28] <helix84> Forgot about this long ago. Sam is right that the text should be i18n-ed, but I'd pull this anyway. This is too late to add new strings.
[20:28] <tdonohue> That text already existed and was not i18n-ed. So, it's not fault of this PR.
[20:28] <bollini> I'm +1 with that as is
[20:28] <mhwood> New Issue to i18n-ize.
[20:28] <hpottinger> tdonohue: re 1481, don't miss the final comment that Richard Rodgers has made a curation task for the job.
[20:29] <tdonohue> hpottinger: yep, will pull it over into the new ticket.
[20:29] <tdonohue> merged 1485 & closed
[20:29] <mhwood> 1485: yes, pull now, fix text later.
[20:29] <bollini> https://jira.duraspace.org/browse/DS-1440
[20:29] <kompewter> [ [DS-1440] restore search form autocomplete in XMLUI (removed in 3.0) - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-1440
[20:30] <kompewter> [ https://jira.duraspace.org/browse/DS-1440 ] - [DS-1440] restore search form autocomplete in XMLUI (removed in 3.0) - DuraSpace JIRA
[20:30] <bollini> I'm creating the issue for i18n...
[20:30] <mhwood> 1440 needs more information. REschedule.
[20:30] <tdonohue> 1440 - needs volunteer & is a new feature. Reschedule for 5.0
[20:30] <bollini> https://jira.duraspace.org/browse/DS-1420
[20:31] <kompewter> [ https://jira.duraspace.org/browse/DS-1420 ] - [DS-1420] Exception handling for deleting a metadata field (XMLUI) - DuraSpace JIRA
[20:31] <kompewter> [ [DS-1420] Exception handling for deleting a metadata field (XMLUI) - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-1420
[20:31] <mhwood> Already vounteer needed. Reschedule.
[20:31] <tdonohue> needs code. reschedule for 4.1
[20:31] <bollini> https://jira.duraspace.org/browse/DS-1418
[20:32] <kompewter> [ https://jira.duraspace.org/browse/DS-1418 ] - [DS-1418] Month names without translation - DuraSpace JIRA
[20:32] <kompewter> [ [DS-1418] Month names without translation - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-1418
[20:32] <tdonohue> reschedule. volunteer needed.
[20:32] <mhwood> Yes.
[20:32] <bollini> https://jira.duraspace.org/browse/DS-1408
[20:32] <kompewter> [ [DS-1408] WorkspaceItemTest fails (Timeout trying to lock table "EPERSON") - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-1408
[20:32] <kompewter> [ https://jira.duraspace.org/browse/DS-1408 ] - [DS-1408] WorkspaceItemTest fails (Timeout trying to lock table "EPERSON") - DuraSpace JIRA
[20:33] <mhwood> Needs more research?
[20:33] * misilot (~misilot@p-body.lib.fit.edu) Quit (Quit: Leaving)
[20:33] <tdonohue> 1408. Ugh. Ok, this is a bug in our *unit testing*, not in the code. Reschedule.
[20:33] <bollini> I have created https://jira.duraspace.org/browse/DS-1821 and reported in the merged PR
[20:34] <kompewter> [ https://jira.duraspace.org/browse/DS-1821 ] - [DS-1821] Internationalize the bitstream access icon alt text - DuraSpace JIRA
[20:34] <kompewter> [ [DS-1821] Internationalize the bitstream access icon alt text - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-1821
[20:34] <bollini> https://jira.duraspace.org/browse/DS-1411
[20:34] <kompewter> [ [DS-1411] uncaught NPE in stats-log-converter -m - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-1411
[20:34] <kompewter> [ https://jira.duraspace.org/browse/DS-1411 ] - [DS-1411] uncaught NPE in stats-log-converter -m - DuraSpace JIRA
[20:34] <mhwood> Reschedule.
[20:35] <bollini> https://jira.duraspace.org/browse/DS-951
[20:35] <kompewter> [ [DS-951] Monthly stats report ignores items archived on first and last day of the month - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-951
[20:35] <kompewter> [ https://jira.duraspace.org/browse/DS-951 ] - [DS-951] Monthly stats report ignores items archived on first and last day of the month - DuraSpace JIRA
[20:35] <helix84> tdonohue: re 1408 - I wouldn't say that the problem is in the unit test
[20:35] <tdonohue> helix84: yea, well it's not a definite DSpace bug (yet). Either way, it can be rescheduled...needs more analysis
[20:36] <tdonohue> 951: has a PR from aschweer
[20:36] <tdonohue> at a glance that PR looks OK. Should we just merge it?
[20:37] <mhwood> Merge it.
[20:37] <aschweer> the code as is has been working for me for a long time :)
[20:37] <bollini> +1
[20:37] <aschweer> I just figured an extra pair of eyes might be useful
[20:37] <tdonohue> merged & closed 951
[20:37] <mhwood> I studied it a bit.
[20:37] <bollini> https://jira.duraspace.org/browse/DS-880
[20:37] <kompewter> [ https://jira.duraspace.org/browse/DS-880 ] - [DS-880] Better documentation for permissions - DuraSpace JIRA
[20:37] <kompewter> [ [DS-880] Better documentation for permissions - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-880
[20:38] <mhwood> Bram is working on it. Unless he has something now, reschedule.
[20:38] <tdonohue> 880 is a docs ticket, and is assigned. Keep it open till the last minute, and reschedule if not ready?
[20:39] <bollini> tdonohue +1
[20:39] <mhwood> That seems reasonable.
[20:39] * misilot (~misilot@p-body.lib.fit.edu) has joined #duraspace
[20:39] <bollini> https://jira.duraspace.org/browse/DS-1789
[20:39] <kompewter> [ [DS-1789] Deprecate Lucene Java classes - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-1789
[20:39] <kompewter> [ https://jira.duraspace.org/browse/DS-1789 ] - [DS-1789] Deprecate Lucene Java classes - DuraSpace JIRA
[20:39] <mhwood> It's +4 with no nonpositive comments.
[20:40] <tdonohue> 1789 was "agreed upon", but not implemented. It's just a matter of adding @deprecate to appropriate classes
[20:40] <tdonohue> anyone willing to add the appropriate Java comment? I'm admittedly swamped this week...worried I won't get to it before RC3
[20:41] <bollini> ok, I will do a PR who volunteer to check (comments and coverage of classes) and merge?
[20:42] <tdonohue> i can help verify
[20:42] <bollini> ok thanks, assigned to me - tim as reviewer
[20:42] <bollini> https://jira.duraspace.org/browse/DS-1808
[20:42] <kompewter> [ [DS-1808] Default metadata schema: differentiate between submission defaults and real system dependencies - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-1808
[20:42] <kompewter> [ https://jira.duraspace.org/browse/DS-1808 ] - [DS-1808] Default metadata schema: differentiate between submission defaults and real system dependencies - DuraSpace JIRA
[20:43] <mhwood> In progress. Reschedule.
[20:44] <bollini> https://jira.duraspace.org/browse/DS-1813 has been merged in the previous hour meeting
[20:44] <kompewter> [ [DS-1813] Unify configurations regarding SubmissionLookup step - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-1813
[20:44] <kompewter> [ https://jira.duraspace.org/browse/DS-1813 ] - [DS-1813] Unify configurations regarding SubmissionLookup step - DuraSpace JIRA
[20:44] <bollini> https://jira.duraspace.org/browse/DS-1769
[20:44] <kompewter> [ https://jira.duraspace.org/browse/DS-1769 ] - [DS-1769] Bootstrap JSPUI - when trying to upload a file, if there is a problem then the error message appears partially hidden beneath the footer. - DuraSpace JIRA
[20:44] <kompewter> [ [DS-1769] Bootstrap JSPUI - when trying to upload a file, if there is a problem then the error message appears partially hidden beneath the footer. - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-1769
[20:44] * lap1 (~l.pascare@host107-220-dynamic.20-87-r.retail.telecomitalia.it) has joined #duraspace
[20:45] <mhwood> In progress. Reschedule.
[20:45] <tdonohue> 1769 - needs reverification. Sounds like it should be rescheduled
[20:45] <bollini> https://jira.duraspace.org/browse/DS-1768
[20:45] <kompewter> [ [DS-1768] Bootstrap JSPUI - when submitting an item the header appears as just a black strip with no branding - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-1768
[20:45] <kompewter> [ https://jira.duraspace.org/browse/DS-1768 ] - [DS-1768] Bootstrap JSPUI - when submitting an item the header appears as just a black strip with no branding - DuraSpace JIRA
[20:46] <bollini> the pr introduce a new jsp to give the possibility to customize the "minimal" navigation bar
[20:46] <tdonohue> 1768: Not as familiar with the code here. But, as bollini was part of writing it, I trust this PR. +1 to merge
[20:46] <mhwood> +1
[20:46] <bollini> the default is the small logo linked to the home, and the user menu
[20:47] <kstamatis> +1 too (I think we [EKT] have reported this as well)
[20:47] <bollini> ok merged
[20:47] <bollini> https://jira.duraspace.org/browse/DS-1812
[20:47] <kompewter> [ https://jira.duraspace.org/browse/DS-1812 ] - [DS-1812] use better image downscaling method for XPDF media-filter - DuraSpace JIRA
[20:47] <kompewter> [ [DS-1812] use better image downscaling method for XPDF media-filter - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-1812
[20:48] <tdonohue> 1812: Not very familiar with this area of the code. But, as Bram approves of the approach, it sounds OK to me
[20:49] <tdonohue> (Although I will note that this looks to add some new configs to dspace.cfg -- they need to get in the docs.)
[20:49] <bollini> it is out of the 4.0 deadline
[20:49] <helix84> I'd prefer to merge this as it's complementary to the JPEG work done in 4.0
[20:50] <bollini> ok, I don't place a veto here... just 0 from me
[20:51] <tdonohue> Oh wait..nevermind, it's not adding new configs. It's reusing existing ones (from the JPEG work, I believe)
[20:51] <tdonohue> my mistake
[20:52] <tdonohue> anyone else? Should we merge? I'm about a +0.5 (still not fully +1, but it looks reasonable enough)
[20:52] <hpottinger> I'm in the same boat, honestly
[20:52] <mhwood> Can we tell whether anyone has tried it?
[20:53] <tdonohue> Maybe we should ask Bram & Jason (submitter)? Leave it open for their response. Then either merge tomorrow or reschedule?
[20:53] <mhwood> Yes. I can be persuaded that this is not quite a new feature.
[20:53] <bollini> +1, I'm not able to test xpdf
[20:54] <bollini> https://jira.duraspace.org/browse/DS-1590
[20:54] <kompewter> [ [DS-1590] Mirage: thumbnail dimensions are not enforced in listings - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-1590
[20:54] <kompewter> [ https://jira.duraspace.org/browse/DS-1590 ] - [DS-1590] Mirage: thumbnail dimensions are not enforced in listings - DuraSpace JIRA
[20:55] <mhwood> This one seems sensible. I didn't know we could use {$foo} there.
[20:56] <tdonohue> +1 to merge 1590
[20:56] <helix84> mhwood: it's XSL :)
[20:56] <tdonohue> merged & closed 1590
[20:57] <bollini> https://jira.duraspace.org/browse/DS-1716
[20:57] <helix84> mhwood: http://www.w3.org/TR/xslt#attribute-value-templates
[20:57] <kompewter> [ https://jira.duraspace.org/browse/DS-1716 ] - [DS-1716] New JSPUI look & feel (Bootstrap) review - DuraSpace JIRA
[20:57] <kompewter> [ XSL Transformations (XSLT) ] - http://www.w3.org/TR/xslt#attribute-value-templates
[20:57] * kshepherd materialises
[20:57] <kompewter> [ [DS-1716] New JSPUI look & feel (Bootstrap) review - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-1716
[20:57] <tdonohue> kshepherd still exists? I thought he turned into an IRC bot?
[20:57] <kshepherd> worse than a bot.. an idle irssi session ;)
[20:57] <tdonohue> haha :)
[20:58] <tdonohue> 1716 - I trust bollini & lap1's judgement here
[20:58] <mhwood> Yes, it's been reviewed.
[20:58] <bollini> I have just a comment about the method signatures
[20:59] <bollini> should lap1 apply the proposed changes or are you fine with the actual signature?
[21:00] <tdonohue> 1716 seems fine to me, once bollini & lap1 are agreed on it, and it gets cleaned up as needed
[21:00] <mhwood> tdonohue++
[21:00] <bollini> ok, leave it open we will merge soon
[21:00] <bollini> https://jira.duraspace.org/browse/DS-1524
[21:00] <kompewter> [ https://jira.duraspace.org/browse/DS-1524 ] - [DS-1524] Incorrect use of Creative Commons corporate logo - DuraSpace JIRA
[21:00] <kompewter> [ [DS-1524] Incorrect use of Creative Commons corporate logo - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-1524
[21:01] * tdonohue notes we only have <15 tickets left. We're at one hour here, but hopefully folks can stick around for a bit longer
[21:01] <mhwood> Resolution of possible interaction with 1818?
[21:01] <hpottinger> inbox 0 here we come!
[21:01] <mhwood> I will be here for another hour.
[21:02] <tdonohue> 1524 seems reasonable to merge. I'm not sure if it's fully related to 1818 (which is about making sure we support Creative Commons 4.0 Licenses)
[21:02] <bollini> I need to go soon but I fully trust you
[21:02] <mhwood> BTW I'm travelling tomorrow but will have computer & check in late in the day.
[21:03] <kshepherd> 1524 seems good to me..
[21:03] <tdonohue> bollini: I can take over posting the ticket numbers...though I'll have to determine what order you are using
[21:03] <lap1> sorry, too fast chat for a newbie like me :-) i'm working on DS-1716 to close it asap
[21:03] <bollini> tdonohue: I will pass to you the remaining issues
[21:03] <kompewter> [ https://jira.duraspace.org/browse/DS-1716 ] - [DS-1716] New JSPUI look & feel (Bootstrap) review - DuraSpace JIRA
[21:04] <tdonohue> thanks, bollini
[21:04] <mhwood> Thank you lap1
[21:05] <tdonohue> merged & closed 1524
[21:05] <tdonohue> DS-1804
[21:05] <kompewter> [ https://jira.duraspace.org/browse/DS-1804 ] - [DS-1804] Two Bugfixes for the DOIIdentifierProvider - DuraSpace JIRA
[21:06] <bollini> ok, I'm leaving now... bye all
[21:06] * bollini (~bollini@host190-215-dynamic.35-79-r.retail.telecomitalia.it) has left #duraspace
[21:07] <tdonohue> 1804 sounds important to merge...it fixes new features in 4.0
[21:08] <tdonohue> i.e., sounds like 1804 is a bug fix to DS-1535
[21:08] <kompewter> [ https://jira.duraspace.org/browse/DS-1535 ] - [DS-1535] DOI support for dspace-api - DuraSpace JIRA
[21:08] <mhwood> Yes it is.
[21:09] <tdonohue> +1 to merge 1804 then. I trust pbecker knows what to fix in 1535, since he wrote the code initially
[21:10] <tdonohue> anyone else? no objections?
[21:10] <mhwood> Yes. Nothing leaps out at me when I read it over.
[21:10] <kshepherd> +1, i think i understand what's going on there, looking at the commits
[21:10] <tdonohue> merged & closed
[21:10] <tdonohue> DS-1819
[21:10] <kompewter> [ https://jira.duraspace.org/browse/DS-1819 ] - [DS-1819] Discovery filters encoding - DuraSpace JIRA
[21:11] <tdonohue> has a PR from KevinVdV
[21:11] <tdonohue> looks minor, +1
[21:11] <kshepherd> simple fix, KVdV knows what he's doing with discovery, +1
[21:12] <tdonohue> merged & closed
[21:12] <mhwood> Seems right.
[21:12] <tdonohue> DS-1803
[21:12] <kompewter> [ https://jira.duraspace.org/browse/DS-1803 ] - [DS-1803] Configurable workflow migration script fails if collection workflow group renamed - DuraSpace JIRA
[21:12] * helix84 (~ctenar@195.178.95.132) Quit (Quit: Lost terminal)
[21:13] * hpottinger hopes we can move towards merging little changes like 1819 ourselves. Fix dem bugs! :-)
[21:13] <tdonohue> 1803 seems reasonable. It's a minor fix to migration scripts for the "Configurable Workflow" (which KevinVdV is also well versed in)
[21:13] <mhwood> 1803: I agree.
[21:14] <kshepherd> i don't know too much about configurable workflow
[21:14] <tdonohue> merged & closed
[21:14] <tdonohue> DS-1752
[21:14] <kompewter> [ https://jira.duraspace.org/browse/DS-1752 ] - [DS-1752] On the submissions page, the titles of completed submissions look odd - DuraSpace JIRA
[21:15] <mhwood> No code. Reschedule.
[21:15] <tdonohue> agreed
[21:15] <tdonohue> rescheduled for 4.1
[21:15] <tdonohue> DS-1448
[21:15] <kompewter> [ https://jira.duraspace.org/browse/DS-1448 ] - [DS-1448] usually harmless "Broken pipe" errors filling up dspace.log - DuraSpace JIRA
[21:15] <kshepherd> no PR for this.. i've done some submission page enhancements for our repository staff recently, maybe i can make it generic and turn it into a PR that fixes this issue too
[21:16] <tdonohue> kshepherd - that'd be great
[21:16] <kshepherd> (+submission dates, 'on-behalf-of' sword users if via sword, dc.type, numbered rows, etc.)
[21:16] <tdonohue> 1448 is "better than what we currently have". May still not be 100% perfect, but better
[21:17] <mhwood> Yes.
[21:17] <tdonohue> so, I'm +1 merging and perhaps fixing more later on.
[21:17] <hpottinger> wait, Bram has a PR on 1448
[21:17] <mhwood> I do agree that we should never swallow exceptions unless we *know* they are meaningless.
[21:17] <kshepherd> well i'm +1 on those errors not being useful, certianly not needing to be full stack traces
[21:18] <mhwood> Yes, too many stack traces....
[21:18] <tdonohue> so, sounds like we are in agreement to merge 1448...we can always clean up even more later on
[21:19] <mhwood> I think so.
[21:20] <tdonohue> merged & closed
[21:20] <tdonohue> DS-1292
[21:20] <kompewter> [ https://jira.duraspace.org/browse/DS-1292 ] - [DS-1292] UI cosmetics item form with controlled vocabulary in xmlui - Mirage theme - DuraSpace JIRA
[21:21] <mhwood> No progress yet. Reschedule.
[21:21] <tdonohue> 1292: I'm pretty sure it's a duplicate (as I stated). I suggest closing
[21:21] * kshepherd isn't 100% certain of work needed
[21:21] <tdonohue> I think DS-1328 fixes it.
[21:21] <kompewter> [ https://jira.duraspace.org/browse/DS-1328 ] - [DS-1328] Subject keyword box breaks layout for long taxonomy values - DuraSpace JIRA
[21:22] <tdonohue> I suggest closing & asking claudia to reopen if it's been misunderstood.
[21:22] <mhwood> Sensible.
[21:22] <tdonohue> closed & commented
[21:23] <tdonohue> DS-824 (I think this is the last one!)
[21:23] <kompewter> [ https://jira.duraspace.org/browse/DS-824 ] - [DS-824] Request Copy function for XMLUI and JSPUI - DuraSpace JIRA
[21:23] <tdonohue> this was merged a long time ago, wasn't it? Oh, it's waiting for docs?
[21:24] <mhwood> That's how it appears to me.
[21:24] <tdonohue> Should we ping helix84 on docs? Or Bram (as it looks like he volunteered)?
[21:25] <tdonohue> Would the RT be willing to ping folks on docs & just close this one?
[21:25] <mhwood> I am.
[21:25] * hpottinger cheers!
[21:26] <tdonohue> that's it! We've reviewed *everything* marked as "fix for 4.0". There's still 9 left open, but we have someone following up on each of them
[21:26] <mhwood> Yay!
[21:27] <tdonohue> Now I'm just really hoping that Bamboo doesn't start yelling at us after all these merges.
[21:28] <hpottinger> Bamboo is quite kind, I'm sure it'll be fine
[21:28] <tdonohue> So, next steps now are RC3...then we need to do some final testing & finalize documentation. Finally, 4.0 Final.
[21:28] <mhwood> Hush, don't jinx it!
[21:29] <tdonohue> It sounds like RC3 is Friday. Do we need to send out a Documentation reminder/ final deadline?
[21:29] <tdonohue> Docs deadline could also be Friday (end of day), or even Monday (to give folks the weekend to finish up if needed)
[21:30] <tdonohue> 4.0 Final could then *hopefully* be end of next week (Dec 12 or 13), assuming the next few steps go smoothly. (I'm leaving a few days buffer there for final tests of RC3, etc)
[21:31] <tdonohue> (This is all totally off the top of my head...please feel free to disagree, or make your own schedule, Release Team.)
[21:31] <mhwood> I have it on my calendar for Wednesday, but there will be an RC3 announcement and we can adjust the release date then.
[21:31] <mhwood> If needed.
[21:32] <mhwood> I emailed Bram about DS-824 documentation.
[21:32] <kompewter> [ https://jira.duraspace.org/browse/DS-824 ] - [DS-824] Request Copy function for XMLUI and JSPUI - DuraSpace JIRA
[21:33] <tdonohue> Weds is fine too. I just wasn't sure if we wanted to add slightly more buffer, and just do the "final stamp of approval" in next week's DevMtg. But, either way works.
[21:33] <mhwood> I have Documentation on my calendar now through Monday.
[21:33] <mhwood> Good idea, having the next meeting for final check.
[21:33] <hpottinger> re DS-1546, I did some research and I have the SHAs of the two commits that comprised the fix, I should be able to make a PR for it, definitely in time for 4.1 but I could make it sooner
[21:33] <kompewter> [ https://jira.duraspace.org/browse/DS-1546 ] - [DS-1546] org.dspace.authenticate.ShibAuthentication.findMultipleHeaders doesn't work for multiple headers, and provides incorrect config advice - DuraSpace JIRA
[21:34] <tdonohue> hpottinger: that sounds fine.
[21:35] <tdonohue> mhwood: Ok, then sounds like 4.0 final is tenatively Dec 12 or 13. I think that sounds good.
[21:36] <tdonohue> One last ticket to mention. bollini (rightly so) had to reopen a ticket we merged & closed today. DS-1733 See his comments
[21:36] <kompewter> [ https://jira.duraspace.org/browse/DS-1733 ] - [DS-1733] Metadata export fails because of items not in archive - DuraSpace JIRA
[21:36] <mhwood> Bamboo finished 2 seconds ago and all is green.
[21:37] <tdonohue> the question with 1733 then is: Do we rollback? Do we work on a different quick fix?
[21:40] <hpottinger> I'm not sure if I understand the concern completely
[21:40] <mhwood> Could reduce the test to "i.getOwningCollection == null" until we have a more comprehensive fix.
[21:41] <tdonohue> hpotting: with 1733 / PR#364 (now merged), we've accidentally removed a feature of Bulk Metadata Editing..the ability to reinstate items. It's now impossible to add withdrawn items to a CSV export
[21:41] <tdonohue> mhwood: good idea
[21:41] <tdonohue> mhwood: that does seem like the most simplistic fix to the NPE problem
[21:42] <mhwood> At least it blows up less often.
[21:42] <hpottinger> I'm not following how it was possible to export withdrawn items, but that's probably because I'm not that involved with content
[21:42] <tdonohue> hpottinger: It was only possible to export withdrawn items via the Bulk Metadata Editor (which is only accessible to Admins)
[21:43] <tdonohue> well, does someone have time to do the "quick fix" version?
[21:44] <tdonohue> Ok, I guess I can try and just push up a quick PR (assuming vagrant-dspace is behaving these days)
[21:45] <hpottinger> vagrant-dspace is working great
[21:46] * kstamatis (6df2ac96@gateway/web/freenode/ip.109.242.172.150) Quit (Quit: Page closed)
[21:46] <tdonohue> well, I think that's all I have for today. Any last thoughts?
[21:46] <tdonohue> BTW...I think 4.0 is looking awesome! Tons of great stuff
[21:47] <hpottinger> I agree, thanks to everyone who showed up early today to slog through the pile of tickets!
[21:47] <mhwood> While we are here: Mirage uses an i18n:text string to externalize "textarea" and I don't know why. ???
[21:47] <tdonohue> mhwood: do you have a GitHub link? Not sure I understand
[21:48] <mhwood> I think it's looking for <dri:textarea>textarea</dri:textarea> to clean something up.
[21:48] <mhwood> Looking for it on Github now.
[21:49] <mhwood> https://github.com/DSpace/DSpace/blob/master/dspace-xmlui/src/main/webapp/themes/Mirage/lib/xsl/core/page-structure.xsl#L224
[21:49] <kompewter> [ DSpace/dspace-xmlui/src/main/webapp/themes/Mirage/lib/xsl/core/page-structure.xsl at master · DSpace/DSpace · GitHub ] - https://github.com/DSpace/DSpace/blob/master/dspace-xmlui/src/main/webapp/themes/Mirage/lib/xsl/core/page-structure.xsl#L224
[21:50] <mhwood> The reason I'm asking is that I think this is all that stands in the way of externalizing a whole largish Javascript script, which would take care of DS-1502 (after 4.0).
[21:50] <kompewter> [ https://jira.duraspace.org/browse/DS-1502 ] - [DS-1502] Invalid XHTML in Javascript generated by Mirage theme - DuraSpace JIRA
[21:51] <tdonohue> Here's the related i18n: https://github.com/DSpace/DSpace/blob/master/dspace-xmlui/src/main/webapp/i18n/messages.xml#L2167
[21:51] <kompewter> [ DSpace/dspace-xmlui/src/main/webapp/i18n/messages.xml at master · DSpace/DSpace · GitHub ] - https://github.com/DSpace/DSpace/blob/master/dspace-xmlui/src/main/webapp/i18n/messages.xml#L2167
[21:51] <tdonohue> I don't know why either..there's an odd comment in the messages.xml about it
[21:51] <mhwood> Ah, it's just space.
[21:52] <mhwood> I can't imagine why this would be changed. i18n is just being used to sneak a parameter into page-structure.xsl.
[21:52] <tdonohue> "blame" says it's been in Mirage from the beginning...added on 2010-10-20 by benbosman as part of DS-710
[21:52] <kompewter> [ https://jira.duraspace.org/browse/DS-710 ] - [DS-710] New Base Theme For DSpace 1.7.0 - DuraSpace JIRA
[21:53] <mhwood> This doesn't have to be resolved today; I just wondered if anyone knew a reason why it was done this way.
[21:53] <tdonohue> I don't know either. It does seem odd, and probably needs to be fixed, as it looks like a "hack" of some sort. But I don't understand it
[21:54] <mhwood> Maybe I will work up a patch that replaces it with a plain string and pushes the script out to a file, and see what comments it garners.
[21:54] <tdonohue> would be worth a try
[21:54] <mhwood> Well, thanks for looking at it.
[21:55] <tdonohue> no problem. I had never noticed that before
[21:56] <mhwood> I made a note to try that. Now I'll try to ignore it until end of next week. :-/
[21:58] <mhwood> Also noting to see if there's some way to get a full suite of XHTML, CSS, Javascript etc. validators to run automatically, triggered by Github merges.
[21:59] <hpottinger> define validator, mhwood :-)
[21:59] <mhwood> "Is this page valid XHTML?"
[22:02] <tdonohue> Alternatively, maybe find a validator to run against demo.dspace.org on occasion? (Especially via testathons).
[22:03] <tdonohue> In reality this isn't something GitHub can really do, as you need to be running DSpace and accessing it from the web to validate the XHTML
[22:04] <tdonohue> So, unless you find something that will deploy DSpace automatically (to Tomcat) to do the validation, I'm not sure it's something we can automate on every commit
[22:04] * linux4u (~james@employed.library.emory.edu) Quit (Ping timeout: 272 seconds)
[22:05] <tdonohue> (Though I guess if we automated the deploy process to demo.dspace.org or similar, then maybe you could make it work...just not sure how easy that all is right now)
[22:06] <mhwood> People do e.g. have Jenkins auto-deploy on successful test runs. We'd need to work over the DSpace installation process a bit, but we need to do that anyway.
[22:06] <mhwood> I should have said Bamboo rather than Github.
[22:06] <mhwood> Anyway, it won't happen very soon. Lots to do.
[22:07] <hpottinger> I know some people tinkering with Travis CI hook scripts to do continuous deployment
[22:07] <hpottinger> not for DSpace, alas
[22:07] <tdonohue> yea, Bamboo or Jenkins could be the answer here... I just haven't ever found time to dig into this area for DSpace (other than the simple CI "sanity" checks that the build works)
[22:08] <mhwood> Got it noted. But for now I have to run.
[22:08] <mhwood> Thanks everybody!
[22:09] <hpottinger> it's an area of interest for me, though the environment here isn't particularly friendly to the notion of continuous deployment
[22:09] <mhwood> Noted. Bye!
[22:10] * mhwood (mwood@mhw.ulib.iupui.edu) has left #duraspace
[22:10] * aschweer (~schweer@schweer.its.waikato.ac.nz) Quit (Quit: leaving)
[22:10] * hpottinger (~hpottinge@mu-161244.dhcp.missouri.edu) has left #duraspace
[22:14] * lap1 (~l.pascare@host107-220-dynamic.20-87-r.retail.telecomitalia.it) has left #duraspace
[23:28] * tdonohue (~tdonohue@c-50-179-112-246.hsd1.il.comcast.net) has left #duraspace
These logs were automatically created by DuraLogBot on irc.freenode.net using the Java IRC LogBot.