Timestamps are in GMT/BST.
[6:50] -orwell.freenode.net- *** Looking up your hostname...
[6:50] -orwell.freenode.net- *** Checking Ident
[6:50] -orwell.freenode.net- *** Found your hostname
[6:50] -orwell.freenode.net- *** No Ident response
[6:50] * DuraLogBot (~PircBot@ec2-107-22-210-74.compute-1.amazonaws.com) has joined #duraspace
[6:50] * Topic is '[Welcome to DuraSpace - This channel is logged - http://irclogs.duraspace.org/]'
[6:50] * Set by cwilper!ad579d86@gateway/web/freenode/ip.173.87.157.134 on Fri Oct 22 01:19:41 UTC 2010
[12:18] * mhwood (mwood@mhw.ulib.iupui.edu) has joined #duraspace
[13:01] * tdonohue (~tdonohue@c-98-215-0-161.hsd1.il.comcast.net) has joined #duraspace
[13:56] * hpottinger (~hpottinge@mu-160056.dhcp.missouri.edu) has joined #duraspace
[15:00] <tdonohue> Hi all, welcome. It's time for our weekly DSpace Dev Mtg. Today's agenda is posted at: https://wiki.duraspace.org/display/DSPACE/DevMtg+2015-04-22
[15:00] <kompewter> [ DevMtg 2015-04-22 - DSpace - DuraSpace Wiki ] - https://wiki.duraspace.org/display/DSPACE/DevMtg+2015-04-22
[15:01] <tdonohue> The first few topics on this agenda are really just quick notes...
[15:02] <tdonohue> 1. I'll be out of the office next week (Weds - Fri), and won't be able to attend this meeting next Weds (April 29 @ 20UTC). Anyone wiling to take the lead on this meeting next week? Or can you all "self-organize" and chat about 5.2?
[15:04] <pbecker> It's a late meeting, I won't make it.
[15:04] <tdonohue> 2. Also just wanted to note that our OR2015 Developer/DCAT meeting now has a Wiki page: https://wiki.duraspace.org/display/DSPACE/DevMtg+2015-06-08+-+OR15+Meeting The exact time of this meeting is still unknown, but it will happen on Monday, June 8. Please feel free to signup and add any ideas of topics you'd like to see discussed
[15:04] <kompewter> [ DevMtg 2015-06-08 - OR15 Meeting - DSpace - DuraSpace Wiki ] - https://wiki.duraspace.org/display/DSPACE/DevMtg+2015-06-08+-+OR15+Meeting
[15:06] <tdonohue> So, lots of silence here. Anyone else planning to be around next week for the DevMtg (20UTC)? Just wanting verification that you all can minimally self-organize and talk more about 5.2 schedule, etc
[15:07] <mhwood> I expect to be here.
[15:08] <tdonohue> Ok, thanks. I'll just assume then that you all will self-organize and talk about important topics. The biggest of course is outstanding 5.2 tickets, and starting to get a handle on when that release may occur.
[15:09] <hpottinger> I'm thinking we should probably nail down a release date maybe today?
[15:09] <tdonohue> Regarding the OR15 face-to-face Dev/DCAT meeting, if anyone has ideas for topics, please do pass them my way or add them to the Wiki page. I'll be working on finalizing the agenda in the coming weeks, once we have a time for the meeting, etc.
[15:09] <tdonohue> hpottinger: we can, if we think we are ready :)
[15:10] <tdonohue> And that is the next topic on the agenda... 5.2 planning / status
[15:10] <tdonohue> Here's the outstanding PRs still tagged for 5.2: https://github.com/DSpace/DSpace/pulls?q=is%3Aopen+is%3Apr+milestone%3A5.2
[15:10] <kompewter> [ Pull Requests · DSpace/DSpace · GitHub ] - https://github.com/DSpace/DSpace/pulls?q=is%3Aopen+is%3Apr+milestone%3A5.2
[15:10] <hpottinger> probably ready? I think DSPR#905 is close, and just needs docs + some advice for usage of the --keep flag
[15:10] <kompewter> [ https://github.com/DSpace/DSpace/pull/905 ] - Ds 2486 reindex solr by aschweer
[15:10] <tdonohue> But, the most important one still is 905 (as noted by hpottinger)
[15:11] <tdonohue> 905 does seem close to me (just from following the discussion). I agree though with the concerns about auto-deleting the entire temp directory (and mhwood's idea of a small refactor sounds nice)
[15:12] <tdonohue> I also notice that aschweer just commented earlier as well about checking for lack of disk space (not sure whether that's fully needed to be a programmatic check though, or if we just add some docs/warnings about it)
[15:13] <hpottinger> yeah, all concerns with 905 I think can be addressed with docs and more usage info in the script
[15:13] <pbecker> I think DS-2545 is a real problem, but I didn't found time yet to investigate more.
[15:13] <kompewter> [ https://jira.duraspace.org/browse/DS-2545 ] - [DS-2545] JSPUI offers collections in the submission process the user is not allowed to commit to - DuraSpace JIRA
[15:14] <hpottinger> helix84 has updated the 5.2 status page: https://wiki.duraspace.org/display/DSPACE/DSpace+Release+5.2+Status
[15:14] <kompewter> [ DSpace Release 5.2 Status - DSpace - DuraSpace Wiki ] - https://wiki.duraspace.org/display/DSPACE/DSpace+Release+5.2+Status
[15:14] <tdonohue> I would note here though that with 905, if the recommendation is to *always* use the "--keep" flag, then that implies the code is likely doing something wrong, and maybe we should quickly fix it
[15:16] <tdonohue> So, i wonder if anyone would want or be willing to add a few more minor fixes to 905? Or is it really ready to merge and release?
[15:16] <hpottinger> tdonohue: my recommendation is if you care about the contents or existence of the temp folder specified in the DIRECTORY_OPTION, you should use the --keep option
[15:16] <hpottinger> and just generally make it clear that the script considers that entire folder disposable
[15:17] <tdonohue> hpottinger: right, I'm just pointing out that seems like a recommendation for "defaulting" to using --keep, unless you are sure you don't want it. Which implies the code has the wrong default setting to me
[15:17] <hpottinger> it's not necessarily "wrong" just "surprising"
[15:18] <tdonohue> surprising is "wrong" when you are talking about auto-deleting content
[15:18] <tdonohue> (at least it is to most sysadmins, I'd assume)
[15:18] <hpottinger> well.. if you don't specify the folder, then the script autocreates it and then cleans up when it's done
[15:18] <tdonohue> So, I'd personally recommend the suggested refactor of 905
[15:19] <hpottinger> mhwood's suggestion?
[15:19] <tdonohue> yep
[15:19] <tdonohue> Or something that at least makes the auto-delete of the directory more "safe". We shouldn't just assume that the directory passed in should be wiped out
[15:19] <mhwood> Problem is that main() knows whether the directory path was supplied and exportIndex knows whether it was created. They don't coordinate.
[15:20] <hpottinger> aschweer has indicated she's pressed for time, I am as well, 905 is based on a feature branch, if anyone has time to refactor that feature branch, please do so
[15:21] <tdonohue> Anyone willing to do that quick refactor on the branch? I just really don't want to see complaints that the "auto-upgrade script just deleted a ton of stuff I needed!" on our lists
[15:22] <mhwood> I'll take a stab at it.
[15:22] <tdonohue> thanks mhwood!
[15:22] <hpottinger> yay!
[15:22] <tdonohue> So, assuming the deletion stuff gets cleaned up a bit, it sounds like 905 is ready to go
[15:23] <tdonohue> stepping back to pbecker's note above on DS-2545
[15:23] <kompewter> [ https://jira.duraspace.org/browse/DS-2545 ] - [DS-2545] JSPUI offers collections in the submission process the user is not allowed to commit to - DuraSpace JIRA
[15:23] <tdonohue> Seems like with 2545, JSPUI should just copy the logic from XMLUI?
[15:24] <pbecker> I know that this worked once.
[15:24] <pbecker> I don't know what broke it.
[15:24] <pbecker> Didn't had the time to investigate further, but I was able to reproduce on demo.
[15:25] <tdonohue> On Demo, it looks like XMLUI works properly with regards to the Collection dropdown from the Submit UI
[15:25] <tdonohue> But, on Demo, JSPUI does NOT work right (it lists all collections)
[15:26] <tdonohue> You can see this behavior by simply logging in as "dspacedemo+submit@gmail.com" in XMLUI and JSPUI on demo site
[15:26] <pbecker> exactly. If a user has no rights to commit to any collection then no collection is listed and a warning is produced.
[15:26] <tdonohue> so, I've verified, this is a bug. XMLUI works, JSPUI doesn't
[15:26] <pbecker> But If the user is allowed to submit to at least one collection all are shown.
[15:26] <tdonohue> So, we probably need to see what is different in their implementations
[15:29] <tdonohue> I added a comment to the ticket that I've verified this bug. I'd agree this seems like something to definitely fix in 5.2
[15:30] <pbecker> I won't have any time this week, but I hope to take a look next week on this issue. If someone else wants to chip in, I would really appreciate it.
[15:30] <hpottinger> pbecker: is there another bug you needed confirmation on?
[15:30] <pbecker> I'm a little bit unsure about DS-2550.
[15:30] <kompewter> [ https://jira.duraspace.org/browse/DS-2550 ] - [DS-2550] ImageMagick/Ghostscript my lead to wrong background color of PDF thumbnails - DuraSpace JIRA
[15:30] <pbecker> thanks, that you asked hpottinger.
[15:31] <pbecker> No one else was able to reproduce it. aschweer wrote that she would give it +1 nevertheless as she understands the problem and the solution in theory.
[15:32] <hpottinger> looks like you just need another +1 and you can "just fix it"
[15:33] <pbecker> :)
[15:33] <pbecker> I just see, that I forgot to label some of my PRs on github.
[15:33] <pbecker> So there are some more PRs ready for 5.2
[15:33] <pbecker> they are all small bugfixes for JSPUI.
[15:34] <hpottinger> can you add them to the 5.2 milestone?
[15:35] <pbecker> yes, I just did.
[15:35] <pbecker> no they should be all in the list tdonohue linked above.
[15:37] <tdonohue> regarding 2550, as long as it doesn't "break" anything it sounds fine
[15:37] <tdonohue> I was digging a tad deeper on DS-2545... I suspect it *might* be related to DS-682 fixes in 5.0 (from peterdietz). I added a comment around that, but I don't know for certain that was the cause'
[15:37] <kompewter> [ https://jira.duraspace.org/browse/DS-2545 ] - [DS-2545] JSPUI offers collections in the submission process the user is not allowed to commit to - DuraSpace JIRA
[15:37] <kompewter> [ https://jira.duraspace.org/browse/DS-682 ] - [DS-682] The Select Collection step performs badly with a large number of collections - DuraSpace JIRA
[15:38] <pbecker> In therory it could break transparency, if anyone uses a format that support transparency (e.g. png) for thumbnails.
[15:38] <pbecker> but we do not have any code to generate thumbnails as png, so it would be a local addon.
[15:39] <hpottinger> can't support code we can't see :-)
[15:39] <tdonohue> sure we do, ImageMagick generates thumbnails from PNG: https://github.com/DSpace/DSpace/blob/master/dspace/config/dspace.cfg#L470
[15:39] <kompewter> [ DSpace/dspace.cfg at master · DSpace/DSpace · GitHub ] - https://github.com/DSpace/DSpace/blob/master/dspace/config/dspace.cfg#L470
[15:39] <tdonohue> notice "image/png" in that list
[15:40] <pbecker> tdononhue I was talking about the "export" format of the thumbnail.
[15:40] <pbecker> And I think this is always jpg.
[15:40] <tdonohue> oh, I see. gotcha. I misunderstood
[15:41] <tdonohue> pbecker: i think 2550 sounds fine to me then. I agree, there's no need to support PNG format thumbnails, since we always generate thumbs in JPG
[15:41] <tdonohue> 2550 is also rather small, and there's a config to turn it off if needed
[15:42] <pbecker> https://github.com/DSpace/DSpace/blob/master/dspace-api/src/main/java/org/dspace/app/mediafilter/ImageMagickThumbnailFilter.java#L70
[15:42] <kompewter> [ DSpace/ImageMagickThumbnailFilter.java at master · DSpace/DSpace · GitHub ] - https://github.com/DSpace/DSpace/blob/master/dspace-api/src/main/java/org/dspace/app/mediafilter/ImageMagickThumbnailFilter.java#L70
[15:42] <pbecker> tdonohue: great. One last question. Do we want this configuration property to be (commented out) in dspace.cfg?
[15:42] <peterdietz> hi all. Sorry to pop in late
[15:43] <pbecker> Or maybe just in the code to keep dspace.cfg slim
[15:43] <pbecker> hi peter
[15:43] <tdonohue> yes, commented out (as you have it) seems best, pbecker. There's no reason to have it uncommented since it's a default setting
[15:43] <pbecker> the question was more whether we want to have it in dspace.cfg at all?
[15:43] <pbecker> We could leave it in the code, but not mention it in dspace.cfg.
[15:43] <mhwood> I would rather have it there, commented.
[15:43] <tdonohue> pbecker: right now we prefer having things commented out, just cause it's essentially "documentation" in dspace.cfg. I prefer not having "hidden" configs that are only findable by browsing code
[15:44] <pbecker> perfect, I agree.
[15:44] <tdonohue> which also brings up a minor point. This config should also be added to the ImageMagick docs for DSpace 5.x
[15:45] <pbecker> of course. I'll merge it tomorrow and write the docs. (have no time for the docs today)
[15:45] <tdonohue> thanks pbecker. Sounds good
[15:45] <tdonohue> peterdietz: when you find a chance, you might want to review DS-2545. It looks possibly related to your fixes to DS-682 which were released in 5.0
[15:45] <kompewter> [ https://jira.duraspace.org/browse/DS-2545 ] - [DS-2545] JSPUI offers collections in the submission process the user is not allowed to commit to - DuraSpace JIRA
[15:45] <kompewter> [ https://jira.duraspace.org/browse/DS-682 ] - [DS-682] The Select Collection step performs badly with a large number of collections - DuraSpace JIRA
[15:46] <peterdietz> i just started to read it over. The code for each ui looks so similar. Seems odd they would behave differently
[15:46] <tdonohue> OK, any other 5.2 tickets or PRs we want to discuss today?
[15:47] <tdonohue> peterdietz: I agree, but it is also happening on the Demo site. So, something must be acting differently between XMLUI and JSPUI
[15:47] * pbecker added a comment to DS-2550 that we decided to merge as it is.
[15:47] <kompewter> [ https://jira.duraspace.org/browse/DS-2550 ] - [DS-2550] ImageMagick/Ghostscript my lead to wrong background color of PDF thumbnails - DuraSpace JIRA
[15:48] <tdonohue> I'll also note that it looks like, with 5.2, we have a lot of smaller (still open) PRs: https://github.com/DSpace/DSpace/pulls?q=is%3Aopen+is%3Apr+milestone%3A5.2
[15:48] <kompewter> [ Pull Requests · DSpace/DSpace · GitHub ] - https://github.com/DSpace/DSpace/pulls?q=is%3Aopen+is%3Apr+milestone%3A5.2
[15:48] <tdonohue> So, if someone feels like doing some merging..there seems like several minor, small fixes that could just be merged & cherry-picked to 5.x in that list
[15:49] <pbecker> I started to create PRs against dspace-5_x branch so no cherry-picking is necessary anymore. hope that helps.
[15:50] <tdonohue> Oh, and looking at that list, I was reminded about DS-2546 / DSPR#918
[15:50] <kompewter> [ https://github.com/DSpace/DSpace/pull/918 ] - [DS-2546] fixes problem in DateUtils parsing by christian-scheible
[15:50] <kompewter> [ https://jira.duraspace.org/browse/DS-2546 ] - [DS-2546] OAI-PMH interface is parsing Dates incorrectly - DuraSpace JIRA
[15:50] <tdonohue> (I tagged this for 5.2 recently as it sounded a bit ugly, but I hadn't had a chance to actually test it myself)
[15:52] <tdonohue> So, if anyone can help verify it, it sounds like an ugly bug where you can never really harvest *everything* from OAI-PMH or OAI-ORE
[15:53] <tdonohue> All this being said, do we want to talk DSpace 5.2 release timelines? It does seem like we are nearing a release date...and may just need a final push over the next week or two.
[15:54] <tdonohue> We could even set a "tentative" goal date (likely at least a few weeks out)
[15:55] <tdonohue> For example, a tentative date of May 7 or May 14 (both are Thursdays)
[15:55] <hpottinger> how about a Wednesday?
[15:55] <hpottinger> 5/13?
[15:55] <tdonohue> Wednesdays are fine too. I just tend to avoid Fri ;)
[15:55] <hpottinger> wait, that's a terrible date for me :-)
[15:55] <hpottinger> 5/14 is better
[15:56] <tdonohue> A tentative release date of 5/14 is fine by me. hpottinger, sounds like you are still volunteering to do the honors of "cutting" the release?
[15:57] <hpottinger> well, I'll do it if no one else wants to... I think pbecker wants to, though...
[15:58] <hpottinger> that was a joke, heh heh
[15:58] <tdonohue> To meet the 5/14 goal, ideally, we'd get all major bugs merged by 5/7 at the latest (one week prior). That'd give us time to then do a quick full system test (e.g. on Demo), etc
[15:59] <peterdietz> JSPUI... what...the...heck... https://github.com/DSpace/DSpace/blob/master/dspace-jspui/src/main/java/org/dspace/app/webui/jsptag/SelectCollectionTag.java#L68
[15:59] <kompewter> [ DSpace/SelectCollectionTag.java at master · DSpace/DSpace · GitHub ] - https://github.com/DSpace/DSpace/blob/master/dspace-jspui/src/main/java/org/dspace/app/webui/jsptag/SelectCollectionTag.java#L68
[15:59] <pbecker> hpottinger: sorry, I was distracted. ;-)
[16:00] <peterdietz> a JSP calls that tag: https://github.com/DSpace/DSpace/blob/master/dspace-jspui/src/main/webapp/submit/start-lookup-submission.jsp#L277
[16:00] <kompewter> [ DSpace/start-lookup-submission.jsp at master · DSpace/DSpace · GitHub ] - https://github.com/DSpace/DSpace/blob/master/dspace-jspui/src/main/webapp/submit/start-lookup-submission.jsp#L277
[16:00] <tdonohue> peterdietz: you may have found the 2545 bug ;)
[16:00] <peterdietz> Bypassing all the logic that the servlet created...
[16:00] <tdonohue> yuck. Definitely add a comment of your findings, peterdietz.
[16:01] <tdonohue> I've updated the 5.2 Status page with the new tentative release date of 5/14: https://wiki.duraspace.org/display/DSPACE/DSpace+Release+5.2+Status
[16:01] <kompewter> [ DSpace Release 5.2 Status - DSpace - DuraSpace Wiki ] - https://wiki.duraspace.org/display/DSPACE/DSpace+Release+5.2+Status
[16:02] * hpottinger prints a calendar, wanders off to pick it up from the printer, brb
[16:03] <tdonohue> Any final thoughts for today? Sounds like we have a general plan in place for 5.2. I'd just encourage everyone to keep chipping away at the PRs listed here: https://github.com/DSpace/DSpace/pulls?q=is%3Aopen+is%3Apr+milestone%3A5.2 (And also any major tickets still needing a PR, like DS-2545)
[16:03] <kompewter> [ Pull Requests · DSpace/DSpace · GitHub ] - https://github.com/DSpace/DSpace/pulls?q=is%3Aopen+is%3Apr+milestone%3A5.2
[16:03] <kompewter> [ https://jira.duraspace.org/browse/DS-2545 ] - [DS-2545] JSPUI offers collections in the submission process the user is not allowed to commit to - DuraSpace JIRA
[16:04] <tdonohue> Ok, we'll close out today's meeting then!
[16:05] <tdonohue> Again, next week, I'll be unavailable, but you all should just touch base on 5.2 and how to move any (still open) PRs / major tickets forward to resolution!
[16:05] * tdonohue notes I'm taking a 5 min break, and then will jump over to #dspace for JIRA backlog hour (for anyone interested)
[16:06] <hpottinger> to repeat the timeline: April 7: freeze master for release, start mini testathon; April 7-13 mini testathon; April 14, cut release 5.2
[16:07] <pbecker> hpottinger, you meant May not April for sure.
[16:07] <hpottinger> shoot, yes
[16:07] <hpottinger> May 13: trick pbecker into volunteering to cut release 5.2
[16:08] <pbecker> :-)
[16:19] * hpottinger adds a few lines to the Dev Meeting agenda for OR15
[16:27] * hpottinger (~hpottinge@mu-160056.dhcp.missouri.edu) Quit (Quit: Leaving, later taterz!)
[18:47] * hpottinger (~hpottinge@mu-160056.dhcp.missouri.edu) has joined #duraspace
[21:05] * mhwood (mwood@mhw.ulib.iupui.edu) has left #duraspace
[21:42] * tdonohue (~tdonohue@c-98-215-0-161.hsd1.il.comcast.net) Quit (Read error: Connection reset by peer)
[22:14] * hpottinger (~hpottinge@mu-160056.dhcp.missouri.edu) Quit (Quit: Leaving, later taterz!)
These logs were automatically created by DuraLogBot on irc.freenode.net using the Java IRC LogBot.