#duraspace IRC Log

Index

IRC Log for 2016-12-07

Timestamps are in GMT/BST.

[2:42] * kshepherd (~kim@lbdigs29.lbr.auckland.ac.nz) Quit (Ping timeout: 250 seconds)
[2:47] * kshepherd (~kim@lbdigs29.lbr.auckland.ac.nz) has joined #duraspace
[4:06] * kshepherd (~kim@lbdigs29.lbr.auckland.ac.nz) Quit (Ping timeout: 248 seconds)
[5:50] * kshepherd (~kim@202.24.255.123.static.snap.net.nz) has joined #duraspace
[6:27] * terry-b (~chrome@97-113-118-39.tukw.qwest.net) Quit (Read error: Connection reset by peer)
[6:28] * terry-b (~chrome@97-113-118-39.tukw.qwest.net) has joined #duraspace
[6:29] * terry-b (~chrome@97-113-118-39.tukw.qwest.net) Quit (Read error: Connection reset by peer)
[6:30] * terry-b (~chrome@97-113-118-39.tukw.qwest.net) has joined #duraspace
[6:53] -verne.freenode.net- *** Looking up your hostname...
[6:53] -verne.freenode.net- *** Checking Ident
[6:53] -verne.freenode.net- *** Found your hostname
[6:53] -verne.freenode.net- *** No Ident response
[6:54] * DuraLogBot (~PircBot@webster.duraspace.org) has joined #duraspace
[6:54] * Topic is 'Welcome to DuraSpace IRC. This channel is used for formal meetings and is logged - http://irclogs.duraspace.org/'
[6:54] * Set by tdonohue on Thu Sep 15 17:49:38 UTC 2016
[11:40] * kshepherd (~kim@202.24.255.123.static.snap.net.nz) Quit (Quit: Lost terminal)
[13:18] * mhwood (mwood@mhw.ulib.iupui.edu) has joined #duraspace
[13:55] * tdonohue (~tdonohue@c-98-220-55-31.hsd1.il.comcast.net) has joined #duraspace
[13:55] * tdonohue (~tdonohue@c-98-220-55-31.hsd1.il.comcast.net) Quit (Changing host)
[13:55] * tdonohue (~tdonohue@dspace/tdonohue) has joined #duraspace
[14:10] * tdonohue (~tdonohue@dspace/tdonohue) has left #duraspace
[14:10] * tdonohue (~tdonohue@dspace/tdonohue) has joined #duraspace
[18:23] * th5 (~th5@unaffiliated/th5) has joined #duraspace
[19:37] * hpottinger (~hpottinge@162.104.218.179) has joined #duraspace
[19:54] <tdonohue> Reminder, DSpace DevMtg starts shortly (at top of hour). Agenda at https://wiki.duraspace.org/display/DSPACE/DevMtg+2016-12-07
[19:54] <kompewter> [ DevMtg 2016-12-07 - DSpace - DuraSpace Wiki ] - https://wiki.duraspace.org/display/DSPACE/DevMtg+2016-12-07
[20:00] <terry-b> Hello
[20:00] <tdonohue> Hello all, pinging Committers for DevMtg time: helix84, hpottinger, mhwood, terry-b
[20:00] <mhwood> Here!
[20:01] <tdonohue> So, as we've done in recent weeks, the goal of this meeting is primarily to keep a finger on the pulse of DSpace 6 "in the wild" and start to resolve/investigate any newly reported issues
[20:02] <tdonohue> To that end, I've been maintaining a list of such DSpace 6 issues in the agenda notes (and others should feel free to add to them prior to each meeting, if I miss something).
[20:02] <tdonohue> First up in that list is not actually a ticket, but I saw this report that DSpace 6 may *require* Git to actually build? https://groups.google.com/forum/#!topic/dspace-tech/ePevCFj8Ofw
[20:02] <kompewter> [ Google Groups ] - https://groups.google.com/forum/#!topic/dspace-tech/ePevCFj8Ofw
[20:03] <terry-b> I have a hndful of PR's waiting for some attention. How should I tag them to get them on the fast track?
[20:03] <tdonohue> That seems very odd to me, and no one responded on the lists...It'd be nice to get someone to investigate that
[20:03] <tdonohue> terry-b: if they are 6.x related bugs, add them to this Agenda list please
[20:04] <terry-b> Will do
[20:05] <tdonohue> Anyone have time to look into whether DSpace 6 *requires* Git? It really *shouldn't*...so if it is doing so, we need to log a bug and resolve in 6.1
[20:06] <terry-b> 4 tickets added to the agenda
[20:07] <tdonohue> no volunteers for Git issues...ok, well, it sounds like this might at least need a ticket to track it.
[20:08] <terry-b> I will create a ticket
[20:08] <mhwood> Actually I just took a quick look, and buildnumber-maven-plugin will indeed call the SCM -- git in our case.
[20:08] <tdonohue> thanks terry-b. If you could respond to the thread, that'd be great too...even if just to say: we created a ticket for this and are investigating
[20:09] <hpottinger> +1 we need a ticket for that for sure
[20:09] <tdonohue> mhwood: that sounds like a bug then, right? Is there a way to get it to *not* call SCM? Is this plugin for figuring out the version of DSpace they are running?
[20:09] <mhwood> Dunno what we are doing with the build number.
[20:10] <tdonohue> ok, sounds like this needs more investigating then (and that aforementioned ticket)
[20:11] <hpottinger> https://github.com/DSpace/DSpace/blob/master/dspace-api/pom.xml#L103-L115
[20:11] <kompewter> [ DSpace/pom.xml at master · DSpace/DSpace · GitHub ] - https://github.com/DSpace/DSpace/blob/master/dspace-api/pom.xml#L103-L115
[20:11] <terry-b> https://jira.duraspace.org/browse/DS-3418
[20:11] <kompewter> [ [DS-3418] DSpace Build Error When Maven is Not Present - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-3418
[20:11] <kompewter> [ https://jira.duraspace.org/browse/DS-3418 ] - [DS-3418] DSpace Build Error When Maven is Not Present - DuraSpace JIRA
[20:11] <terry-b> Oops, I will correct the title
[20:11] <terry-b> https://jira.duraspace.org/browse/DS-3418
[20:11] <hpottinger> https://github.com/DSpace/DSpace/commit/913577eaf151d3c407a308fb24760d21bb212be0
[20:11] <kompewter> [ Add SCM revision number (= git commit hash) and branch name (but the · DSpace/DSpace@913577e · GitHub ] - https://github.com/DSpace/DSpace/commit/913577eaf151d3c407a308fb24760d21bb212be0
[20:11] <kompewter> [ [DS-3418] DSpace Build Error When Git is Not Present - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-3418
[20:11] <kompewter> [ https://jira.duraspace.org/browse/DS-3418 ] - [DS-3418] DSpace Build Error When Git is Not Present - DuraSpace JIRA
[20:11] <mhwood> It looks like we can skip the SCM version if we don't want it. Perhaps that will suppress going to look for it.
[20:12] <tdonohue> ok, please do write notes in the new ticket then... and/or claim it. Sounds like it should hopefully be fixable
[20:13] <mhwood> OK
[20:13] <tdonohue> next up... recently we had two bugs logged regarding DSpace 6 + Oracle (along with proposed PRs): DS-3409 and DS-3410
[20:13] <kompewter> [ https://jira.duraspace.org/browse/DS-3409 ] - [DS-3409] Handle of collections and communities are lost during migration using oracle - DuraSpace JIRA
[20:14] <kompewter> [ https://jira.duraspace.org/browse/DS-3410 ] - [DS-3410] Indexes are lost at oracle - DuraSpace JIRA
[20:14] <tdonohue> with 3409, here's the DSPR#1579
[20:14] <kompewter> [ https://github.com/DSpace/DSpace/pull/1579 ] - DS-3409 Handle of collections and communities are lost by arvoConsultores
[20:15] <tdonohue> looks like for this one, we had a bad migration here... luckily at a glance it looks fixable with a new migration (But it needs testing)
[20:16] <tdonohue> And 3410 has DSPR#1580 ... it's just restoring some DB indexes which were accidentally dropped
[20:16] <kompewter> [ https://github.com/DSpace/DSpace/pull/1580 ] - Deleting collumns drop indexes by arvoConsultores
[20:17] <tdonohue> Any volunteers here for these? They seem very thorny for Oracle users
[20:18] <mhwood> Am I the only one here who still has Oracle?
[20:18] <hpottinger> there was a very brief discussion here about using Oracle, I whimpered until it stopped
[20:19] <tdonohue> you may be, mhwood
[20:19] <mhwood> Sounds like that's a "yes" then.
[20:19] <mhwood> OK, I'll add these to my list.
[20:19] <tdonohue> thanks mhwood!
[20:20] <tdonohue> Ok, next up is this ugly bug from last week: DS-3406
[20:20] <kompewter> [ https://jira.duraspace.org/browse/DS-3406 ] - [DS-3406] Sub-communities and collections not sorted alphabetically - DuraSpace JIRA
[20:20] <tdonohue> hpottinger is assigned here.. any updates?
[20:21] <hpottinger> none, off my radar
[20:22] <tdonohue> ok, this seems like one high-priority for 6.1, as this is very unexpected and user facing. So, if you can find time to look at it, great...otherwise, if anyone else has time to do some (even just initial) digging, it'd also be nice
[20:24] <hpottinger> I unassigned it and moved it back to "needs volunteer"
[20:24] <tdonohue> next in our list is DS-3367
[20:24] <kompewter> [ https://jira.duraspace.org/browse/DS-3367 ] - [DS-3367] Configurable Workflow authorization denied error - DuraSpace JIRA
[20:24] <tdonohue> assigned to mhwood... any updates?
[20:24] <mhwood> Sorry, none.
[20:25] <tdonohue> ok, moving on to DS-3381 which is at needs volunteer
[20:25] <kompewter> [ https://jira.duraspace.org/browse/DS-3381 ] - [DS-3381] Blocking error trying the versioning system - DuraSpace JIRA
[20:25] <tdonohue> this one seems to block versioning (though it needs verification first)
[20:26] <tdonohue> just going to move along (but please note that any of these tickets are up for grabs... if you want one, claim it please...if you aren't a committer, you can still submit a PR!)
[20:27] <tdonohue> DS-3389 is still a known issue with Replication Task Suite + DSpace 6
[20:27] <kompewter> [ https://jira.duraspace.org/browse/DS-3389 ] - [DS-3389] Replication Task Suite add-on doesn&#39;t work with DSpace 6 API - DuraSpace JIRA
[20:27] <tdonohue> hpottinger, I'm assuming this one also likely has had little traction (no worries)
[20:28] <tdonohue> the next few are all added by terry-b
[20:28] <tdonohue> starting with DS-3348 / DSPR#1542
[20:28] <kompewter> [ https://github.com/DSpace/DSpace/pull/1542 ] - [DS-3348] Drop date check in EmbargoService by terrywbrady
[20:28] <kompewter> [ https://jira.duraspace.org/browse/DS-3348 ] - [DS-3348] Allow AIP Restore of items with a lift date in the past - DuraSpace JIRA
[20:30] <mhwood> Needs a rebase, but the idea sounds reasonable.
[20:30] <mhwood> It's at +1 right now.
[20:30] <tdonohue> How does this change affect JSPUI, terry-b? I notice it's an API level change, but just mentions XMLUI
[20:30] <terry-b> I don't run JSPUI. Someone will need to test that
[20:31] <terry-b> I clicked the "Update Branch" button... I will see what that reports when it is done.
[20:31] <tdonohue> ok, I think this needs testing on JSPUI. The change seems OK, as long as it doesn't detrimentally affect either UI
[20:32] <tdonohue> Looks like pbecker gave a +1 in a text comment only, and forgot to actually submit an "Approval" review (which is why the PR says "Review Required" and "Merging is blocked")
[20:33] <tdonohue> once tested with JSPUI though, this seems fine. Any volunteers to test it? Perhaps we ping pbecker (who I think may run JSPUI) to do so?
[20:33] <hpottinger> I'll test it, we use JSPUI
[20:33] <tdonohue> thanks hpottinger!
[20:33] <terry-b> thanks!
[20:34] <tdonohue> next up on this list... DS-3283
[20:34] <kompewter> [ https://jira.duraspace.org/browse/DS-3283 ] - [DS-3283] Mirage2: Edit Collection Source - No Field Label for Set Id - DuraSpace JIRA
[20:34] <tdonohue> which seems to have two PRs? DSPR#1544 and DSPR#1546 (Not sure if this is a mistake)
[20:34] <kompewter> [ https://github.com/DSpace/DSpace/pull/1544 ] - [DS-3283] Improve OAI Set Id Label Placement for Mirage and Mirage2 by terrywbrady
[20:34] <kompewter> [ https://github.com/DSpace/DSpace/pull/1546 ] - [DS-3283] Fix js error for filters with dashes by terrywbrady
[20:35] <tdonohue> 1544 has conflicts with master it seems
[20:35] <tdonohue> 1546 looks to be mismarked. It seems to be a different ticket
[20:36] <tdonohue> I corrected 1546
[20:36] <terry-b> I will look at the conflict.
[20:37] <tdonohue> I also just realized the "milestone" on these tickets all needs updating. Looks like we forgot to close out the 6.0 milestone in GitHub. All the open 6.0 tickets should be moved to the 6.1 milestone
[20:38] <tdonohue> there's not many of them...I can take care of cleaning up the milestone quickly
[20:38] <mhwood> Thank you.
[20:39] <tdonohue> I will say that 1544 seems rather small..hopefully we can get it's merge conflict fixed and get it tested & merged quickly
[20:39] <tdonohue> moving along though... DS-3334 / DSPR#1543
[20:39] <kompewter> [ https://jira.duraspace.org/browse/DS-3334 ] - [DS-3334] XMLUI Archived Submissions display in chronological order (in DSpace 5 it was reverse chronological) - DuraSpace JIRA
[20:39] <kompewter> [ https://github.com/DSpace/DSpace/pull/1543 ] - [DS-3334] Allow reverse-chronological sort of submitters by terrywbrady
[20:40] <tdonohue> PR also has a conflict...has a +1 from pbecker
[20:41] <tdonohue> This seems somewhat similar to DS-3406 (mentioned above) in that it's a simple sorting error. My guess is that 3406 may be fixed similarly (by fixing the query sort by)
[20:41] <kompewter> [ https://jira.duraspace.org/browse/DS-3406 ] - [DS-3406] Sub-communities and collections not sorted alphabetically - DuraSpace JIRA
[20:41] <terry-b> Darn. These finally get some attention and now they are all in conflict!
[20:41] <tdonohue> terry-b: it's bound to happen just after a release, to be honest ;)
[20:42] <terry-b> Can I trust the recommendation in GitHub for resolving conflict... it seems to suggest that I push to my local master
[20:43] <terry-b> Do you all have a recommended approach for resolution?
[20:43] <mhwood> If I ever followed its advice, I probably disliked the result and never did that again. I'd just rebase on current master.
[20:43] <tdonohue> yes, rebase on current master is the best way
[20:44] <terry-b> Could you give me the command to use?
[20:44] <terry-b> It has been a while sin I did a rebase
[20:44] <tdonohue> Are you working from a forked project?
[20:44] <terry-b> Yes
[20:44] <tdonohue> 1. git remote update (update all remotes)
[20:45] <hpottinger> https://gist.github.com/8738b9fcad5f2a682796baf375393326
[20:45] <tdonohue> 2. git checkout master (checkout local master)
[20:45] <kompewter> [ - · GitHub ] - https://gist.github.com/8738b9fcad5f2a682796baf375393326
[20:45] <tdonohue> hpottinger has better details... I just tend to do "git remote update" instead of his "git fetch --all"... ends up the same
[20:46] <terry-b> thanks for the refresher!
[20:47] <tdonohue> back to our list then... huh, the last one is a repeat... terry-b looks like you listed ticket 3348 twice?
[20:47] <tdonohue> Is that a typo? Was there another one you wanted reviewed?
[20:47] <terry-b> one sec please
[20:49] <terry-b> https://jira.duraspace.org/browse/DS-3282
[20:49] <kompewter> [ https://jira.duraspace.org/browse/DS-3282 ] - [DS-3282] Mirage2: Advanced Search Filters Do Not Display if one contains a &quot;-&quot; - DuraSpace JIRA
[20:49] <kompewter> [ [DS-3282] Mirage2: Advanced Search Filters Do Not Display if one contains a "-" - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-3282
[20:49] <tdonohue> ok, DSPR#1546 is it's PR
[20:49] <kompewter> [ https://github.com/DSpace/DSpace/pull/1546 ] - [DS-3282] Fix js error for filters with dashes by terrywbrady
[20:49] <tdonohue> another out of date branch, but changes look tiny
[20:50] <terry-b> OK. I will get these rebased
[20:51] <tdonohue> thanks!
[20:51] <tdonohue> Other 6.0 tickets/PRs we should look at next?
[20:53] <tdonohue> Ok, hearing none
[20:54] <tdonohue> As we are nearly out of time here, I don't think we have time to do much JIRA backlog. I'm going to spend this time cleaning up our 6.0 milestone in GitHub (already started in the background here)
[20:54] <tdonohue> Any final comments/topics/questions from anyone before we close the meeting?
[20:56] <tdonohue> Ok, hearing none...we'll close up the meeting for today then. Thanks all!
[20:57] <mhwood> Later....
[20:57] <hpottinger> Thanks!
[20:57] * hpottinger (~hpottinge@162.104.218.179) Quit (Quit: Leaving, later taterz!)
[21:28] <terry-b> How can I edit a PR associated with a jira?
[21:59] * th5 (~th5@unaffiliated/th5) Quit ()
[22:03] * mhwood (mwood@mhw.ulib.iupui.edu) Quit (Remote host closed the connection)
[22:56] * tdonohue (~tdonohue@dspace/tdonohue) has left #duraspace
[23:01] * hpottinger (~hpottinge@162.104.218.179) has joined #duraspace
[23:01] <hpottinger> for the log-checkers: I've started DS-3389: https://github.com/hardyoyo/dspace-replicate/tree/DS-3389-refactor-for-dspace-6
[23:01] <kompewter> [ GitHub - hardyoyo/dspace-replicate at DS-3389-refactor-for-dspace-6 ] - https://github.com/hardyoyo/dspace-replicate/tree/DS-3389-refactor-for-dspace-6
[23:01] <kompewter> [ https://jira.duraspace.org/browse/DS-3389 ] - [DS-3389] Replication Task Suite add-on doesn&#39;t work with DSpace 6 API - DuraSpace JIRA
[23:01] <kompewter> [ https://jira.duraspace.org/browse/DS-3389 ] - [DS-3389] Replication Task Suite add-on doesn&#39;t work with DSpace 6 API - DuraSpace JIRA
[23:02] <hpottinger> lots still to do: UUID's are not integers
[23:02] * hpottinger (~hpottinge@162.104.218.179) Quit (Client Quit)

These logs were automatically created by DuraLogBot on irc.freenode.net using the Java IRC LogBot.