#duraspace IRC Log

Index

IRC Log for 2017-05-10

Timestamps are in GMT/BST.

[6:36] -card.freenode.net- *** Looking up your hostname...
[6:36] -card.freenode.net- *** Checking Ident
[6:36] -card.freenode.net- *** Found your hostname
[6:36] -card.freenode.net- *** No Ident response
[6:36] * DuraLogBot (~PircBot@webster.duraspace.org) has joined #duraspace
[6:36] * Topic is 'Welcome to DuraSpace IRC. This channel is used for formal meetings and is logged - http://irclogs.duraspace.org/'
[6:36] * Set by tdonohue on Thu Sep 15 17:49:38 UTC 2016
[11:58] * mhwood (~mhwood@mhw.ulib.iupui.edu) has joined #duraspace
[14:55] * snadeau (84cb8257@gateway/web/freenode/ip.132.203.130.87) has joined #duraspace
[15:45] * hpottinger (~hpottinge@162.104.218.179) has joined #duraspace
[19:57] <mhwood> Reminder: DSpace development meeting coming up at the top of the hour.
[19:57] <hpottinger> Agenda: https://wiki.duraspace.org/display/DSPACE/DevMtg+2017-05-10
[19:57] <kompewter> [ DevMtg 2017-05-10 - DSpace - DuraSpace Wiki ] - https://wiki.duraspace.org/display/DSPACE/DevMtg+2017-05-10
[19:57] <mhwood> Wow, slack sounds like popcorn popping with so many bots.
[19:58] <hpottinger> banhammer those bots?
[19:58] <hpottinger> alas I'm not an operator
[19:59] * DSpaceSlackBot3 (~DSpaceSla@ec2-50-17-201-82.compute-1.amazonaws.com) Quit (Remote host closed the connection)
[19:59] <hpottinger> somebody must be
[19:59] <hpottinger> popcorn better now?
[20:01] <hpottinger> well this is a tiny meeting, role call?
[20:02] <snadeau> I'm just an observer
[20:02] <hpottinger> welcome, snadeau!
[20:02] <snadeau> thanks!
[20:02] <snadeau> I'm from Laval University
[20:03] <hpottinger> well... I know mhwood and kshepherd are here
[20:04] <snadeau> Will there be a moment to ask n00b questions?
[20:04] <hpottinger> yes, let's see what kind of normal business we can conduct with so few people here
[20:05] * DSpaceSlackBot (~DSpaceSla@ec2-50-17-201-82.compute-1.amazonaws.com) Quit (Remote host closed the connection)
[20:05] <hpottinger> OK, here's the agenda again: https://wiki.duraspace.org/display/DSPACE/DevMtg+2017-05-10
[20:05] <kompewter> [ DevMtg 2017-05-10 - DSpace - DuraSpace Wiki ] - https://wiki.duraspace.org/display/DSPACE/DevMtg+2017-05-10
[20:05] * DSpaceSlackBot (~DSpaceSla@ec2-50-17-201-82.compute-1.amazonaws.com) has joined #duraspace
[20:06] <hpottinger> We typically talk about the upcoming release (6.1 and possibly 5x and 4x maintenance bumps as well)
[20:06] <mhwood> Is the slack side seeing this?
[20:06] <DSpaceSlackBot> <hpottinger> yes
[20:06] <mhwood> OK, bot is working (but still attached to my session, so I'll just leave that up for the meeting).
[20:07] <hpottinger> might need to NOHUP it?
[20:07] <mhwood> I'll fix it later.
[20:07] <hpottinger> anyay, yes, we can sort that out later, it's working now
[20:07] <DSpaceSlackBot> Action: kshepherd is sort of here but also skyping for another meeting
[20:08] <DSpaceSlackBot> <kshepherd> snadeu: i'll be in #dspace and slack 'tech-support' after this meeting if you'd like to ask questions
[20:08] <hpottinger> so, let's look at high priority tickets, code review, and hold off on the discussion items on the off chance someone else will wander in?
[20:08] <mhwood> OK
[20:09] <hpottinger> high priority tickets: https://jira.duraspace.org/browse/DS-3551?jql=filter%20%3D%2013904%20ORDER%20BY%20fixVersion%20DESC%2C%20priority%20DESC%20%20%20
[20:09] <kompewter> [ Issue Navigator - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-3551?jql=filter%20%3D%2013904%20ORDER%20BY%20fixVersion%20DESC%2C%20priority%20DESC%20%20%20
[20:09] <kompewter> [ https://jira.duraspace.org/browse/DS-3551 ] - [DS-3551] DSpace 5x XMLUI open two simultaneous DB connections to serve one item page view or bitstream download - DuraSpace JIRA
[20:10] <hpottinger> gosh, most of these are waiting for code review
[20:11] <hpottinger> OK, maybe someone needs to call out this list on the dspace-dev mail list
[20:12] <mhwood> URL not working for me; I just get 3551.
[20:12] <hpottinger> try https://wiki.duraspace.org/display/DSPACE/DevMtg+2017-05-10 and expand thi high priority tickets
[20:12] <kompewter> [ DevMtg 2017-05-10 - DSpace - DuraSpace Wiki ] - https://wiki.duraspace.org/display/DSPACE/DevMtg+2017-05-10
[20:12] <mhwood> Yes, better.
[20:13] <hpottinger> https://jira.duraspace.org/browse/DS-3551?filter=13904
[20:13] <kompewter> [ Issue Navigator - DuraSpace JIRA ] - https://jira.duraspace.org/browse/DS-3551?filter=13904
[20:13] <kompewter> [ https://jira.duraspace.org/browse/DS-3551 ] - [DS-3551] DSpace 5x XMLUI open two simultaneous DB connections to serve one item page view or bitstream download - DuraSpace JIRA
[20:14] <hpottinger> or possibly this: https://jira.duraspace.org/issues?filter=13904
[20:14] <kompewter> [ Issue Navigator - DuraSpace JIRA ] - https://jira.duraspace.org/issues?filter=13904
[20:16] <hpottinger> DS-3520 was incorrectly marked as affecting 6x, I've un-marked it
[20:16] <kompewter> [ https://jira.duraspace.org/browse/DS-3520 ] - ('Unexpected error:', <type 'exceptions.AttributeError'>)
[20:16] <mhwood> So there's a bunch of 7.0 stuff at the bottom, one claimed, two volunteer needed (3582, 3287) and a bunch needing review.
[20:16] <hpottinger> let's stipulate that we will let 7.x stuff be handled by the 7x crew?
[20:16] <mhwood> Yes.
[20:17] <hpottinger> which reminds me, I should do some reminders
[20:17] <hpottinger> https://wiki.duraspace.org/display/DSPACE/DSpace+7+UI+Working+Group#DSpace7UIWorkingGroup-NextMeeting
[20:17] <kompewter> [ DSpace 7 UI Working Group - DSpace - DuraSpace Wiki ] - https://wiki.duraspace.org/display/DSPACE/DSpace+7+UI+Working+Group#DSpace7UIWorkingGroup-NextMeeting
[20:18] <hpottinger> The next DSpace 7 UI meeting is TOMORROW, May 11 at 15:00 UTC (11:00am EDT) in Slack
[20:18] <hpottinger> details on the DSpace 7 UI Working Group page: https://wiki.duraspace.org/display/DSPACE/DSpace+7+UI+Working+Group
[20:18] <kompewter> [ DSpace 7 UI Working Group - DSpace - DuraSpace Wiki ] - https://wiki.duraspace.org/display/DSPACE/DSpace+7+UI+Working+Group
[20:19] <hpottinger> All are welcome to attend, if your just curious or if you've been participating. If you've been waiting to jump in on development, I think they are getting close to a code base that will be "fun to play with" :-)
[20:20] <hpottinger> OK, so, after the meeting, I will draft a plea for help testing all of these tickets that have PRs waiting to test
[20:21] <hpottinger> DS-3287 is marked as high priority, and needs volunteer
[20:21] <kompewter> [ https://jira.duraspace.org/browse/DS-3287 ] - [DS-3287] ElasticSearch Statistics fails in 6.0 (does not work at all) - DuraSpace JIRA
[20:22] <hpottinger> to be blunt, it looks a bit like a tombstone
[20:22] <mhwood> The problem is that we don't have anyone who works with ES nowadays.
[20:22] <hpottinger> I think it's OK to walk away from code we don't use
[20:23] <mhwood> Well, we don't have any regular developers who do ES. There may be sites using it that are not prepared to contribute a solution.
[20:23] <mhwood> Clearly someone is using ES, or there would be no ticket.
[20:24] <hpottinger> OK, maybe this is the best we can do: needs volunteer, high priority
[20:24] <mhwood> I think so.
[20:24] <hpottinger> should we drop the fix version?
[20:25] <mhwood> Yes. I don't like to, but we can't have a release waiting on someone who hasn't been found.
[20:25] <hpottinger> done
[20:26] <hpottinger> can't be helped, won't be sad about it
[20:27] <hpottinger> OK, so, I'll call out all the code review tickets in an e-mail, next we have new tickets from this week
[20:28] <hpottinger> 5 of them, I'll call each one out here, we've sorted these in the backlog hour
[20:28] <hpottinger> DS-3587, DS-3588, DS-3589, DS-3590, DS-3591
[20:28] <kompewter> [ https://jira.duraspace.org/browse/DS-3587 ] - [DS-3587] Add support for MySQL databases - DuraSpace JIRA
[20:28] <kompewter> [ https://jira.duraspace.org/browse/DS-3588 ] - [DS-3588] CORS headers on the demo server - DuraSpace JIRA
[20:28] <kompewter> [ https://jira.duraspace.org/browse/DS-3589 ] - [DS-3589] Implement signposting pattern in DSpace - DuraSpace JIRA
[20:28] <kompewter> [ https://jira.duraspace.org/browse/DS-3590 ] - [DS-3590] Implement ResourceSync for DSpace - DuraSpace JIRA
[20:29] <kompewter> [ https://jira.duraspace.org/browse/DS-3591 ] - [DS-3591] Curation task &#39;requiredmetadata&#39; should have a mode to report all problems - DuraSpace JIRA
[20:29] <hpottinger> all of them are "needs volunteer"
[20:29] <hpottinger> a few are for DSpace 7
[20:30] <hpottinger> DS-3591 is a good one to call out
[20:30] <kompewter> [ https://jira.duraspace.org/browse/DS-3591 ] - [DS-3591] Curation task &#39;requiredmetadata&#39; should have a mode to report all problems - DuraSpace JIRA
[20:30] <DSpaceSlackBot> <terrywbrady> Just lurking here. I would not recommend adding support for another database until we have a functional REST 7 API. We have enough complexity to port.
[20:30] <hpottinger> TerryBrady++
[20:31] <mhwood> There is discussion of the broader "support more DBMSs" in DS-3372.
[20:31] <kompewter> [ https://jira.duraspace.org/browse/DS-3372 ] - [DS-3372] Add support for more SQL Dialects (MySQL, SQL Server, more?) - DuraSpace JIRA
[20:31] <hpottinger> Also... we don't add new features in bugfix releases
[20:32] <DSpaceSlackBot> <terrywbrady> That sounds like the more generalized ticket
[20:32] <hpottinger> right, we probably should discuss as a group (maybe on the mail list?) whether and which dialects we want to carry along with us on our journey
[20:33] <mhwood> Yes. Every dialect means another growing collection of migration scripts.
[20:34] <hpottinger> general ticket: DS-3372
[20:34] <kompewter> [ https://jira.duraspace.org/browse/DS-3372 ] - [DS-3372] Add support for more SQL Dialects (MySQL, SQL Server, more?) - DuraSpace JIRA
[20:34] <hpottinger> so... I'll send an e-mail to dspace-dev asking for discussion of DS-3372 in general, and DS-3587 in specific
[20:34] <kompewter> [ https://jira.duraspace.org/browse/DS-3372 ] - [DS-3372] Add support for more SQL Dialects (MySQL, SQL Server, more?) - DuraSpace JIRA
[20:34] <kompewter> [ https://jira.duraspace.org/browse/DS-3587 ] - [DS-3587] Add support for MySQL databases - DuraSpace JIRA
[20:35] <hpottinger> it sounds like @mire has something ready for MySQL, which, if true, changes things a bit
[20:36] <hpottinger> MySQL is opensource, and thus as easy to test as PostgreSQL, it's a high-demand feature
[20:37] <hpottinger> if the code is ready to test, I think it would be silly to bat it away... however, I do think the larger discussion is important, so I'll kick it off on the mail list
[20:37] <mhwood> Thanks!
[20:39] <hpottinger> OK, next on our list of tickets on the agenda are the tickets that are old, but have activity this week https://wiki.duraspace.org/display/DSPACE/DevMtg+2017-05-10
[20:39] <kompewter> [ DevMtg 2017-05-10 - DSpace - DuraSpace Wiki ] - https://wiki.duraspace.org/display/DSPACE/DevMtg+2017-05-10
[20:40] <hpottinger> DS-3582 needs a volunteer, *and* has some ideas for solutions in the comments
[20:40] <kompewter> [ https://jira.duraspace.org/browse/DS-3582 ] - ('Unexpected error:', <type 'exceptions.AttributeError'>)
[20:41] <hpottinger> DS-3557 is probably low hanging fruit
[20:42] <kompewter> [ https://jira.duraspace.org/browse/DS-3557 ] - [DS-3557] dependency on multiple Apache Jena versions - DuraSpace JIRA
[20:43] <hpottinger> marked it as such
[20:45] <hpottinger> DS-2227 has a comment on how to clean up a failed AIP import
[20:45] <kompewter> [ https://jira.duraspace.org/browse/DS-2227 ] - [DS-2227] failed AIP import leaves files in assetstore - DuraSpace JIRA
[20:45] <hpottinger> maybe we move this to needs documentation?
[20:47] <mhwood> Maybe that is best. Hard to recover from OOM.
[20:47] <mhwood> And cleanup should be done regularly anyway.
[20:48] <hpottinger> Ivan asks for a cleanup method, Alan suggests a cleanup method, we're just waiting on the docs
[20:48] <hpottinger> tagged this for 6.1 so hopefully we can pick it up in our dash towards the finish line
[20:49] <mhwood> Ivan wants DSpace to Just Take Care Of It. But that means *another* file to be cleaned up. I think I favor "do this, which you should be doing regularly anyway."
[20:49] <hpottinger> +1
[20:50] <hpottinger> in fact, it might be construed as a "good thing" that we let the AIP files hang out after a failure
[20:51] <hpottinger> perhaps autodeltion might be surprising
[20:51] <hpottinger> the current behavior is perfectly fitting for a repository, I'd say
[20:52] <hpottinger> delete with intention, and carefully
[20:53] <mhwood> OK, if nobody objects, I'll fix the documentation and we'll let that be that?
[20:53] <hpottinger> no objections, thanks, mhwood!
[20:53] <hpottinger> assign it to yourself?
[20:54] <mhwood> Done.
[20:54] <hpottinger> OK, skipping over the list of closed tickets, and the backlog is back at zero -flex-
[20:54] <hpottinger> ᕦ(ᐛ)ᕤ
[20:54] <mhwood> I don't like to interrupt list grooming, but we have someone waiting patiently for a chance to ask a question...
[20:55] <hpottinger> yes, we're done with tickets, let's pause for a question... though this channel is logged
[20:55] <hpottinger> (5 minutes left for our meeting, btw)
[20:56] <mhwood> snadeau had a question?
[20:57] <hpottinger> only thing left on the agenda was our two discussions Spring? and SQL dialects? both can be moved to the mail list
[20:58] <snadeau> I have a question with GitHub Pull requests
[20:58] <snadeau> Should I go to #dspace or ask it here?
[20:58] <hpottinger> go ahead, just know you are being recorded :-)
[20:59] <snadeau> Ok, I'm working on DS-3164 Item statistic displays UUID of bitstreams instead of name
[20:59] <kompewter> [ https://jira.duraspace.org/browse/DS-3164 ] - [DS-3164] Item statistic displays UUID of bitstreams instead of name - DuraSpace JIRA
[20:59] <snadeau> That's a bug I corrected locally and I would like to contribute a fix. It's a low hanging fruit, so trivial, a single line of code.
[21:00] <mhwood> Thank you!
[21:00] <snadeau> So I forked the DSpace GitHub repo in my own GitHub account and cloned it locally
[21:00] <hpottinger> Tim's right, you don't need push rights to make a PR, anybody can make a PR
[21:00] <snadeau> I started a new branch named DS-3164, coded the fix, commited and made a Pull request to my own fork.
[21:00] <kompewter> [ https://jira.duraspace.org/browse/DS-3164 ] - [DS-3164] Item statistic displays UUID of bitstreams instead of name - DuraSpace JIRA
[21:01] <hpottinger> OK, so you have a new branch called DS-3164
[21:01] <snadeau> Well, that's where I'm stuck. when I try to send a Pull request, I'm getting that message.
[21:01] <kompewter> [ https://jira.duraspace.org/browse/DS-3164 ] - [DS-3164] Item statistic displays UUID of bitstreams instead of name - DuraSpace JIRA
[21:01] <hpottinger> a pull request is not a push :-)
[21:02] <hpottinger> in github, if you open up your branch in your fork of DSpace, you should see a button offering to compare or create a PR
[21:02] <snadeau> Ok, but well, when I used the push command on my own fork, it created a Pull request on Github, so I'm new to all this, please tell me what I should do.
[21:02] <snadeau> I'm used to SVN and TFS, but GitHib is new.
[21:03] <snadeau> Ok hpottinger let me see...
[21:03] <hpottinger> a Pull Request is a branch in your fork, which you kindly offer to us, to pull your commits from into our branch
[21:04] <snadeau> Ok, so I need to send the Pull Request from my fork, not from my local copy?
[21:04] <hpottinger> the workflow is: make changes in your working copy, gather the commits in a branch, push that branch to your fork, then, via the GitHub UI, you make a PR agains the upstream branch your branch is based on (probably dspace-6_x)
[21:05] <snadeau> Yes, dspace-6_x, so I should do a Pull Request in that branch?
[21:05] <hpottinger> Mark Diggory had a presentation on this he gave at Open Repositories in Edinburgh, let me see if I can find the slides
[21:05] <snadeau> Ok, that would be great.
[21:06] <snadeau> Ho, by the way, my Pull Request just worked :-)
[21:06] <snadeau> https://github.com/DSpace/DSpace/pull/1744
[21:06] <kompewter> [ Dspace 6 x by Generalelektrix · Pull Request #1744 · DSpace/DSpace · GitHub ] - https://github.com/DSpace/DSpace/pull/1744
[21:07] <hpottinger> the process is: push your branch up to your fork of DSpace on github, then find that branch on github.com, look for the compare or PR button, click it, and ensure you're comparing against the upstream branch you intend to compare with
[21:07] <snadeau> Weee! my first PR :-)
[21:07] <hpottinger> cool!
[21:07] <snadeau> "Generalelektrix wants to merge 2 commits into DSpace:dspace-6_x from Generalelektrix:dspace-6_x"
[21:07] <DSpaceSlackBot> <terrywbrady> The process can feel complicated at first, but it makes the reviews and testing by others much easier
[21:08] <hpottinger> https://github.com/DSpace/DSpace/pull/1744/files a one-liner
[21:08] <kompewter> [ Dspace 6 x by Generalelektrix · Pull Request #1744 · DSpace/DSpace · GitHub ] - https://github.com/DSpace/DSpace/pull/1744/files
[21:08] <snadeau> I understand perfectly.
[21:08] <mhwood> Don't panic if something goes wrong, now or later. We can help you unwind it.
[21:08] <snadeau> Yeash, I have a live update: hardyoyo approved these changes just now - +1 obviously correct
[21:09] <hpottinger> I'm watching the Travis build
[21:09] <snadeau> Thank you everybody, I will certainly contribute more.
[21:09] <hpottinger> yay!!
[21:10] <mhwood> One comment: it's good to mention the Jira ticket number in the PR title, and say what you fixed, so it's easy to spot in a list of PRs.
[21:10] <snadeau> Ok.
[21:10] <mhwood> The ticket number will cause it to be automatically linked back to the ticket (eventually).
[21:11] <hpottinger> mhwood: is right, about the Jira link, and about the help... we're usually always in here
[21:11] <hpottinger> which is a blessing and a curse :-)
[21:11] <mhwood> You'll see the style if you browse the list of PRs on DSpace/DSpace.
[21:11] <snadeau> I will do
[21:12] <mhwood> Thank you.
[21:12] <snadeau> Will see you later!
[21:12] <hpottinger> if you get in the habit of putting the ticket number in your commit messages, it helps
[21:12] <snadeau> I did put it in the commit, but not the PR
[21:12] <snadeau> will do in the future
[21:13] <mhwood> Yes, I forgot that. But I always edit the default title so that it talks about the problem instead of my solution.
[21:13] <hpottinger> snadeau: as soon as this Travis run completes, I'll merge it, unless someone objects
[21:13] <mhwood> No objection.
[21:13] <snadeau> Ok, thenk you everybody. I must leave now.
[21:14] * snadeau (84cb8257@gateway/web/freenode/ip.132.203.130.87) Quit (Quit: Page closed)
[21:14] <hpottinger> well, we should take questions more often, eh?
[21:14] <mhwood> Yes.
[21:14] <mhwood> I must go now, and I'll need to take the bot down for a moment and rerun it nohup.
[21:14] <mhwood> Meeting adjourned?
[21:15] <hpottinger> indeed
[21:15] * hpottinger pounds the gavel
[21:15] * DSpaceSlackBot (~DSpaceSla@ec2-50-17-201-82.compute-1.amazonaws.com) Quit (Remote host closed the connection)
[21:15] * DSpaceSlackBot (~DSpaceSla@ec2-50-17-201-82.compute-1.amazonaws.com) has joined #duraspace
[21:16] <mhwood> OK, I restarted it 'nohup', ^Z, and logged out. Hello test...
[21:16] <mhwood> ...works! Bye, all.
[21:16] * mhwood (~mhwood@mhw.ulib.iupui.edu) has left #duraspace
[21:30] * hpottinger (~hpottinge@162.104.218.179) Quit (Quit: Leaving 三三ᕕ( ᐛ )ᕗ LATER TATERS!)

These logs were automatically created by DuraLogBot on irc.freenode.net using the Java IRC LogBot.